Issue 324383004: ninja win: Remove obsolete comment, and make sure cc/cxx are always overridden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 324383004: ninja win: Remove obsolete comment, and make sure cc/cxx are always overridden (Closed)

Created:
6 years, 6 months ago by scottmg

Modified:
6 years, 6 months ago

Reviewers:
yukawa

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

ninja win: Remove obsolete comment, and make sure cc/cxx are always overridden Builds on discussion in https://codereview.chromium.org/321813002/. Make sure that cc_host and cxx_host are also set to a valid compiler, which fixes the cflags test. R=yukawa@chromium.org BUG=chromium:233985 Committed: https://code.google.com/p/gyp/source/detail?r=1933

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	pylib/gyp/generator/ninja.py	View		2 chunks	+6 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

scottmg

6 years, 6 months ago (2014-06-11 23:52:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r1933 (presubmit successful).