Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 324383003: Teach grit that file.svg is an SVG. (Closed)

Created:
6 years, 6 months ago by Daniel Bratell
Modified:
6 years, 6 months ago
Reviewers:
Nico, newt (away)
CC:
grit-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master
Visibility:
Public.

Description

Teach grit that file.svg is an SVG. When dropping the reliance of platform mime databases we also lost support for the svg mime type. Readding it specifically. Also added an explicit failure if something similar happens in the future. BUG=383189 R=newt@chromium.org Committed: https://code.google.com/p/grit-i18n/source/detail?r=169

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M grit/format/html_inline.py View 1 3 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Daniel Bratell
newt, can you please take a look at this fix to get spinners working in ...
6 years, 6 months ago (2014-06-11 15:23:51 UTC) #1
newt (away)
lgtm, though I'd also recommend removing FixupMimeType() https://codereview.chromium.org/324383003/diff/1/grit/format/html_inline.py File grit/format/html_inline.py (right): https://codereview.chromium.org/324383003/diff/1/grit/format/html_inline.py#newcode125 grit/format/html_inline.py:125: mimetype = ...
6 years, 6 months ago (2014-06-11 18:31:26 UTC) #2
Daniel Bratell
newt, removed the Fixup that is no longer needed. Nice catch. Please take another look ...
6 years, 6 months ago (2014-06-12 07:47:36 UTC) #3
newt (away)
lgtm. landing this now...
6 years, 6 months ago (2014-06-12 18:22:59 UTC) #4
newt (away)
6 years, 6 months ago (2014-06-12 18:36:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r169 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698