Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 324353002: NaCl: Update revision in DEPS, r13309 -> r13318 (Closed)

Created:
6 years, 6 months ago by Mark Seaborn
Modified:
6 years, 6 months ago
Reviewers:
bradn
CC:
chromium-reviews, David Yen, JF, Roland McGrath, Mark Seaborn, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r13309 -> r13318 This pulls in the following Native Client changes: r13310: (dyen) Commands for toolchain_build are now filtered before invoking anything. r13311: (dyen) Fix for needing to push to ssh URL for toolchain_build sources. r13312: (mcgrathr) Disable seccomp-bpf tests under ASan r13313: (mcgrathr) Disable LSan (leak detection) in ASan tests r13314: (mseaborn) Enable the -Wstrict-prototypes warning for untrusted code in the Gyp build r13315: (dyen) Python logging now organized to use loggers instead of global variables. r13316: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13317: (jfb) Update revision for PNaCl r13281->r13311 r13318: (jfb) Update revision for PNaCl r13311->r13316 BUG=none TEST=browser_tests and nacl_integration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Mark Seaborn
6 years, 6 months ago (2014-06-11 15:03:06 UTC) #1
bradn
lgtm
6 years, 6 months ago (2014-06-11 16:28:35 UTC) #2
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 6 months ago (2014-06-11 18:11:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/324353002/1
6 years, 6 months ago (2014-06-11 18:13:33 UTC) #4
commit-bot: I haz the power
Change committed as 276475
6 years, 6 months ago (2014-06-11 19:33:11 UTC) #5
please use gerrit instead
Appears to break compile in http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=68537. Will revert. Sorry for the inconvenience. [4881/17619 | 131.870] ...
6 years, 6 months ago (2014-06-11 19:56:17 UTC) #6
please use gerrit instead
6 years, 6 months ago (2014-06-11 19:57:43 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/326383004/ by rouslan@chromium.org.

The reason for reverting is: The change appears to have broken
http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chro....

Powered by Google App Engine
This is Rietveld 408576698