Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 324343002: [SyncFS] Support late authentication (Closed)

Created:
6 years, 6 months ago by tzik
Modified:
6 years, 6 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] Support late authentication - Make observers to external services sticky over re-initialization. - Leave SyncWorker NULL when non sign-in state. - Observe sign-in event and trigger initialization on it. BUG=374101, 380615 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276591

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -44 lines) Patch
M chrome/browser/sync_file_system/drive_backend/sync_engine.h View 1 2 3 4 4 chunks +18 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 1 2 3 4 22 chunks +132 lines, -28 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.cc View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker_interface.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
tzik
PTL
6 years, 6 months ago (2014-06-11 10:13:12 UTC) #1
peria
lgtm
6 years, 6 months ago (2014-06-11 10:51:55 UTC) #2
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-06-11 11:13:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/324343002/20003
6 years, 6 months ago (2014-06-11 11:16:51 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 20:39:29 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:04:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19537)
6 years, 6 months ago (2014-06-11 21:04:22 UTC) #7
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-06-12 01:51:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/324343002/20003
6 years, 6 months ago (2014-06-12 01:54:34 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 02:54:49 UTC) #10
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-06-12 03:51:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/324343002/50001
6 years, 6 months ago (2014-06-12 03:53:42 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 08:59:27 UTC) #13
Message was sent while issue was closed.
Change committed as 276591

Powered by Google App Engine
This is Rietveld 408576698