Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 32433010: Add performance.now() to the d8 shell. (Closed)

Created:
7 years, 2 months ago by Benedikt Meurer
Modified:
7 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -21 lines) Patch
M src/d8.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/d8.cc View 3 chunks +17 lines, -0 lines 0 comments Download
A + test/mjsunit/d8-performance-now.js View 1 1 chunk +28 lines, -21 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Benedikt Meurer
Hey Hannes, Here's window.performance.now() as requested. :-) PTAL -- Benedikt
7 years, 2 months ago (2013-10-23 08:06:06 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/32433010/diff/1/test/mjsunit/d8-performance-now.js File test/mjsunit/d8-performance-now.js (right): https://codereview.chromium.org/32433010/diff/1/test/mjsunit/d8-performance-now.js#newcode29 test/mjsunit/d8-performance-now.js:29: // sense with d8. Can we revive the old ...
7 years, 2 months ago (2013-10-23 09:59:51 UTC) #2
Benedikt Meurer
PTAL https://codereview.chromium.org/32433010/diff/1/test/mjsunit/d8-performance-now.js File test/mjsunit/d8-performance-now.js (right): https://codereview.chromium.org/32433010/diff/1/test/mjsunit/d8-performance-now.js#newcode29 test/mjsunit/d8-performance-now.js:29: // sense with d8. On 2013/10/23 09:59:51, Hannes ...
7 years, 2 months ago (2013-10-24 09:00:49 UTC) #3
Hannes Payer (out of office)
LGTM
7 years, 2 months ago (2013-10-24 09:25:29 UTC) #4
Benedikt Meurer
Committed patchset #2 manually as r17366 (presubmit successful).
7 years, 2 months ago (2013-10-24 09:27:24 UTC) #5
Benedikt Meurer
Committed patchset #2 manually as r17368.
7 years, 2 months ago (2013-10-24 10:48:25 UTC) #6
Benedikt Meurer
7 years, 2 months ago (2013-10-24 12:25:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r17375 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698