Issue 3243009: Review execute permissions on text files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3243009: Review execute permissions on text files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by danno

Modified:
4 years ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, jam, Paweł Hajdan Jr., darin-cc_chromium.org, stuartmorgan+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Review execute permissions on text files BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57795

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-2 lines, --2 lines)			Patch
	A	chrome/app/policy/windows/admx/chrome.admx	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
	A	chrome/app/policy/windows/admx/en-US/chrome.adml	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download

Trybot results:

Total messages: 1 (0 generated)

okee