Change FontFaceSet#check() behavior when no matched font-face

Change FontFaceSet#check() behavior when no matched font-face

When the font name passed to check() does not match any font face in the
FontFaceSet, current implementation always returns true.  As per the
latest spec draft [1], it should return true if it matches platform font
name, otherwise false.

[1] http://dev.w3.org/csswg/css-font-loading/#font-face-set-check

BUG=378989
TEST=fast/css/fontfaceset-check-platform-fonts.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176278

[bashi, 2014-06-13 06:55:15]

non-owner LGTM with one question.

https://codereview.chromium.org/324293003/diff/70001/Source/core/css/FontFace...
File Source/core/css/FontFaceSet.cpp (right):

https://codereview.chromium.org/324293003/diff/70001/Source/core/css/FontFace...
Source/core/css/FontFaceSet.cpp:492: }
Question: If face is null, it seems that we assume the CSSSegmentedFontFace is
loaded. Is it OK?

[bashi, 2014-06-13 07:13:17]

On 2014/06/13 06:55:15, bashi1 wrote:
> non-owner LGTM with one question.
> 
>
https://codereview.chromium.org/324293003/diff/70001/Source/core/css/FontFace...
> File Source/core/css/FontFaceSet.cpp (right):
> 
>
https://codereview.chromium.org/324293003/diff/70001/Source/core/css/FontFace...
> Source/core/css/FontFaceSet.cpp:492: }
> Question: If face is null, it seems that we assume the CSSSegmentedFontFace is
> loaded. Is it OK?

Chatted offline. This for loop checks whether there is a loading font. |face|
won't null when the font is loading so it's fine.

[dglazkov, 2014-06-13 15:08:37]

lgtm

[Kunihiko Sakamoto, 2014-06-17 01:54:19]

The CQ bit was checked by ksakamoto@chromium.org

[commit-bot: I haz the power, 2014-06-17 01:55:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/324293003/70001

[commit-bot: I haz the power, 2014-06-17 03:32:45]

Change committed as 176278