dart/sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart - Issue 324293002: Improve parser error recovery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart

Issue 324293002: Improve parser error recovery. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Johnni's comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart b/dart/sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart

index 4eeed62456597f72bc236fa67ce440920278b403..3d35ffedfa90912f0d237a17a2b7b73ff2f463a1 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart

@@ -174,6 +174,7 @@ class MemberListener extends NodeListener {

}

void endFields(int count, Token beginToken, Token endToken) {

+ bool hasParseError = memberErrors.head;

super.endFields(count, beginToken, endToken);

VariableDefinitions variableDefinitions = popNode();

Modifiers modifiers = variableDefinitions.modifiers;

@@ -185,7 +186,8 @@ class MemberListener extends NodeListener {

}

buildFieldElements(modifiers, variableDefinitions.definitions,

enclosingElement,

- buildFieldElement, beginToken, endToken);

+ buildFieldElement, beginToken, endToken,

+ hasParseError);

}

void endInitializer(Token assignmentOperator) {