Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: net/quic/quic_flags.cc

Issue 324283004: Rename FLAGS_enable_quic_connection_flow_control to FLAGS_enable_quic_connection_flow_control_2, an… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minimizing diffs Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_flags.h ('k') | net/quic/quic_flow_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_flags.h" 5 #include "net/quic/quic_flags.h"
6 6
7 // TODO(rtenneti): Remove this. 7 // TODO(rtenneti): Remove this.
8 // Do not flip this flag until the flakiness of the 8 // Do not flip this flag until the flakiness of the
9 // net/tools/quic/end_to_end_test is fixed. 9 // net/tools/quic/end_to_end_test is fixed.
10 // If true, then QUIC connections will track the retransmission history of a 10 // If true, then QUIC connections will track the retransmission history of a
11 // packet so that an ack of a previous transmission will ack the data of all 11 // packet so that an ack of a previous transmission will ack the data of all
12 // other transmissions. 12 // other transmissions.
13 bool FLAGS_track_retransmission_history = false; 13 bool FLAGS_track_retransmission_history = false;
14 14
15 // Do not remove this flag until the Finch-trials described in b/11706275 15 // Do not remove this flag until the Finch-trials described in b/11706275
16 // are complete. 16 // are complete.
17 // If true, QUIC connections will support the use of a pacing algorithm when 17 // If true, QUIC connections will support the use of a pacing algorithm when
18 // sending packets, in an attempt to reduce packet loss. The client must also 18 // sending packets, in an attempt to reduce packet loss. The client must also
19 // request pacing for the server to enable it. 19 // request pacing for the server to enable it.
20 bool FLAGS_enable_quic_pacing = true; 20 bool FLAGS_enable_quic_pacing = true;
21 21
22 // Do not remove this flag until b/11792453 is marked as Fixed. 22 // Do not remove this flag until b/11792453 is marked as Fixed.
23 // If true, turns on stream flow control in QUIC. 23 // If true, turns on stream flow control in QUIC.
24 // If this is disabled, all in flight QUIC connections talking QUIC_VERSION_17 24 // If this is disabled, all in flight QUIC connections talking QUIC_VERSION_17
25 // or higher will timeout. New connections will be fine. 25 // or higher will timeout. New connections will be fine.
26 // If disabling this flag, also disable enable_quic_connection_flow_control. 26 // If disabling this flag, also disable enable_quic_connection_flow_control_2.
27 bool FLAGS_enable_quic_stream_flow_control_2 = true; 27 bool FLAGS_enable_quic_stream_flow_control_2 = true;
28 28
29 // Do not remove this flag until b/11792453 is marked as Fixed. 29 // Do not remove this flag until b/11792453 is marked as Fixed.
30 // If true, turns on connection level flow control in QUIC. 30 // If true, turns on connection level flow control in QUIC.
31 // If this is disabled, all in flight QUIC connections talking QUIC_VERSION_19 31 // If this is disabled, all in flight QUIC connections talking QUIC_VERSION_19
32 // or higher will timeout. New connections will be fine. 32 // or higher will timeout. New connections will be fine.
33 // Disabled due to b/15084203. 33 bool FLAGS_enable_quic_connection_flow_control_2 = true;
34 bool FLAGS_enable_quic_connection_flow_control = false;
35 34
36 bool FLAGS_quic_allow_oversized_packets_for_test = false; 35 bool FLAGS_quic_allow_oversized_packets_for_test = false;
37 36
38 // When true, the use time based loss detection instead of nack. 37 // When true, the use time based loss detection instead of nack.
39 bool FLAGS_quic_use_time_loss_detection = false; 38 bool FLAGS_quic_use_time_loss_detection = false;
40 39
41 // If true, allow peer port migration of established QUIC connections. 40 // If true, allow peer port migration of established QUIC connections.
42 bool FLAGS_quic_allow_port_migration = true; 41 bool FLAGS_quic_allow_port_migration = true;
OLDNEW
« no previous file with comments | « net/quic/quic_flags.h ('k') | net/quic/quic_flow_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698