Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 324283003: Move search_terms_data to components/search_engines (Closed)

Created:
6 years, 6 months ago by hashimoto
Modified:
6 years, 6 months ago
Reviewers:
Peter Kasting, sky
CC:
chromium-reviews, creis+watch_chromium.org, Avi (use Gerrit), skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, browser-components-watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, ajwong+watch_chromium.org, kmadhusu+watch_chromium.org, James Su, Jered, blundell
Visibility:
Public.

Description

Move search_terms_data to components/search_engines Rename chrome/browser/search_terms_data* to ui_thread_search_terms_data*. Split SearchTermsData to a separate file and move it to components/search_engines. Add DEPS from components/search_engines to components/google/core as it's used in search_terms_data.cc. BUG=383283 TEST=git cl try TBR=sky@chromium.org for include fix and DEPS removal Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276704

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -673 lines) Patch
M chrome/browser/autocomplete/history_url_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search/instant_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/instant_unittest_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/search_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/default_search_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_host_to_urls_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_provider_install_data.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/search_engines/search_terms_data.h View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/search_engines/search_terms_data.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D chrome/browser/search_engines/search_terms_data_android.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/search_engines/search_terms_data_android.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/search_engines/template_url.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/search_engines/ui_thread_search_terms_data.h View 2 chunks +4 lines, -52 lines 0 comments Download
A + chrome/browser/search_engines/ui_thread_search_terms_data.cc View 4 chunks +2 lines, -57 lines 0 comments Download
A + chrome/browser/search_engines/ui_thread_search_terms_data_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/search_engines/ui_thread_search_terms_data_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/tab_model/tab_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/android/toolbar/toolbar_model_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/webdata/keyword_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M components/search_engines.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + components/search_engines/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + components/search_engines/search_terms_data.h View 3 chunks +3 lines, -32 lines 0 comments Download
A + components/search_engines/search_terms_data.cc View 2 chunks +1 line, -146 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
hashimoto
Peter, could you review this change?
6 years, 6 months ago (2014-06-11 12:15:59 UTC) #1
hashimoto
cc: blundell@chromium.org
6 years, 6 months ago (2014-06-11 12:16:42 UTC) #2
Peter Kasting
LGTM
6 years, 6 months ago (2014-06-11 18:43:44 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-12 00:06:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/324283003/70001
6 years, 6 months ago (2014-06-12 00:09:09 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 00:53:07 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 00:58:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/21994)
6 years, 6 months ago (2014-06-12 00:58:31 UTC) #8
hashimoto
TBRing sky@chromium.org for DEPS removal from c/b/webdata and include fix in c/b/profile_resetter, c/b/renderer_context_menu and c/b/seach.
6 years, 6 months ago (2014-06-12 01:32:48 UTC) #9
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-12 01:32:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/324283003/70001
6 years, 6 months ago (2014-06-12 01:35:51 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 02:16:55 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 02:23:38 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19973)
6 years, 6 months ago (2014-06-12 02:23:39 UTC) #14
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-12 07:22:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/324283003/70001
6 years, 6 months ago (2014-06-12 07:26:31 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 09:15:47 UTC) #17
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-12 10:04:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/324283003/90001
6 years, 6 months ago (2014-06-12 10:07:20 UTC) #19
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 16:26:13 UTC) #20
Message was sent while issue was closed.
Change committed as 276704

Powered by Google App Engine
This is Rietveld 408576698