Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8019)

Unified Diff: chrome/browser/search/search_unittest.cc

Issue 324273004: Allow non default prefetch suggestions to be prefetched (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Autocomplete result check added Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/search_unittest.cc
diff --git a/chrome/browser/search/search_unittest.cc b/chrome/browser/search/search_unittest.cc
index 543ec009b05b228637c22a1aff8df677fa5a8276..30ae4a8a202f127d1e8b748fbcf9fda883eea197 100644
--- a/chrome/browser/search/search_unittest.cc
+++ b/chrome/browser/search/search_unittest.cc
@@ -689,6 +689,41 @@ TEST_F(SearchTest, ShouldPrefetchSearchResults_EnabledViaFieldTrial) {
EXPECT_EQ(80ul, EmbeddedSearchPageVersion());
}
+TEST_F(SearchTest, ShouldPrefetchSearchResults_EnabledViaCommandLine) {
+ CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kPrefetchSearchResults);
+ // Command-line enable should override Finch.
+ ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
+ "EmbeddedSearch", "Group1 espv:80 prefetch_results:0"));
+ EXPECT_TRUE(ShouldPrefetchSearchResults());
+ EXPECT_EQ(80ul, EmbeddedSearchPageVersion());
+}
+
+TEST_F(SearchTest,
+ ShouldAllowPrefetchNonDefaultMatch_PrefetchResultsFlagDisabled) {
+ ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
+ "EmbeddedSearch",
+ "Group1 espv:80 prefetch_results:0 allow_prefetch_non_default_match:1"));
+ EXPECT_FALSE(ShouldAllowPrefetchNonDefaultMatch());
+ EXPECT_EQ(80ul, EmbeddedSearchPageVersion());
+}
+
+TEST_F(SearchTest, ShouldAllowPrefetchNonDefaultMatch_DisabledViaFieldTrial) {
+ ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
+ "EmbeddedSearch",
+ "Group1 espv:89 prefetch_results:1 allow_prefetch_non_default_match:0"));
+ EXPECT_FALSE(ShouldAllowPrefetchNonDefaultMatch());
+ EXPECT_EQ(89ul, EmbeddedSearchPageVersion());
+}
+
+TEST_F(SearchTest, ShouldAllowPrefetchNonDefaultMatch_EnabledViaFieldTrial) {
+ ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
+ "EmbeddedSearch",
+ "Group1 espv:80 prefetch_results:1 allow_prefetch_non_default_match:1"));
+ EXPECT_TRUE(ShouldAllowPrefetchNonDefaultMatch());
+ EXPECT_EQ(80ul, EmbeddedSearchPageVersion());
+}
+
TEST_F(SearchTest,
ShouldPrerenderInstantUrlOnOmniboxFocus_PrefetchResultsFlagDisabled) {
ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
@@ -719,17 +754,6 @@ TEST_F(SearchTest,
EXPECT_EQ(80ul, EmbeddedSearchPageVersion());
}
-TEST_F(SearchTest, ShouldPrefetchSearchResults_EnabledViaCommandLine) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kPrefetchSearchResults);
- // Command-line enable should override Finch.
- ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
- "EmbeddedSearch",
- "Group1 espv:80 prefetch_results:0"));
- EXPECT_TRUE(ShouldPrefetchSearchResults());
- EXPECT_EQ(80ul, EmbeddedSearchPageVersion());
-}
-
TEST_F(SearchTest,
ShouldReuseInstantSearchBasePage_PrefetchResultsFlagDisabled) {
ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(

Powered by Google App Engine
This is Rietveld 408576698