Issue 324253005: rendering_helper - Activate the appropriate texture target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 324253005: rendering_helper - Activate the appropriate texture target. (Closed)

Created:
6 years, 6 months ago by Owen Lin

Modified:
6 years, 6 months ago

Reviewers:
yuli, scherkus (not reviewing), Pawel Osciak, piman

CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

The program crashed if the platform didn't support GL_TEXTURE_EXTERNAL_OES at all. Since only one of GL_TEXTURE_2D and GL_TEXTURE_EXTERNAL_OES would be used. Switch active texture according to the target type and unbound the texture after use. BUG=chromium:383414 TEST=Run the unittest on link and peach-pit Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277977

Patch Set 1 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
	M	content/common/gpu/media/rendering_helper.cc	View		1 chunk	+4 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/324253005/20001

6 years, 6 months ago (2014-06-18 02:18:04 UTC) #4

Message was sent while issue was closed.

Change committed as 277977

Expand Messages | Collapse Messages