Issue 324253004: Update GetNextSpillIndex to support x32 port.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 324253004: Update GetNextSpillIndex to support x32 port. (Closed)

Created:
6 years, 6 months ago by haitao.feng

Modified:
6 years, 6 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Update GetNextSpillIndex to support x32 port. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21954

Patch Set 2 : Added comments #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	src/x64/lithium-x64.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

https://codereview.chromium.org/324253004/diff/1/src/x64/lithium-x64.cc File src/x64/lithium-x64.cc (right): https://codereview.chromium.org/324253004/diff/1/src/x64/lithium-x64.cc#newcode338 src/x64/lithium-x64.cc:338: spill_slot_count_ |= 1; Can you comment what this is ...

6 years, 6 months ago (2014-06-12 09:12:13 UTC) #2

haitao.feng

Please let me know if I need to remove this line and the comments. Currently ...

6 years, 6 months ago (2014-06-13 05:15:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21954.

Expand Messages | Collapse Messages

Issue 324253004: Update GetNextSpillIndex to support x32 port. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added comments #

Messages