Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 324253003: [fsp] Remove remaining space indicator for provided volumes. (Closed)

Created:
6 years, 6 months ago by mtomasz
Modified:
6 years, 6 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

[fsp] Remove remaining space indicator for provided volumes. Fetching remaining space is not implemented yet, hence we should not show the indicator in Files app for provided file systems. Note, that since provided file systems are read only, there is no actual need for this feature. This is temporary. Once the R/W support is added, we should bring back the indicator. TEST=Tested manually with experimental providing extensions. BUG=375020 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276433

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 5 chunks +23 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mtomasz
@hirono: PTAL. Thanks.
6 years, 6 months ago (2014-06-11 01:52:21 UTC) #1
hirono
On 2014/06/11 01:52:21, mtomasz wrote: > @hirono: PTAL. Thanks. This is not fault of the ...
6 years, 6 months ago (2014-06-11 03:24:30 UTC) #2
hirono
https://codereview.chromium.org/324253003/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js File ui/file_manager/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/324253003/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode170 ui/file_manager/file_manager/foreground/js/file_manager.js:170: * Update the element to display the information about ...
6 years, 6 months ago (2014-06-11 03:24:36 UTC) #3
mtomasz
https://codereview.chromium.org/324253003/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js File ui/file_manager/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/324253003/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode170 ui/file_manager/file_manager/foreground/js/file_manager.js:170: * Update the element to display the information about ...
6 years, 6 months ago (2014-06-11 07:19:09 UTC) #4
hirono
On 2014/06/11 07:19:09, mtomasz wrote: > https://codereview.chromium.org/324253003/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js > File ui/file_manager/file_manager/foreground/js/file_manager.js (right): > > https://codereview.chromium.org/324253003/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode170 > ...
6 years, 6 months ago (2014-06-11 07:20:57 UTC) #5
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 6 months ago (2014-06-11 07:21:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/324253003/20001
6 years, 6 months ago (2014-06-11 07:22:35 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 13:21:33 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 17:08:38 UTC) #9
Message was sent while issue was closed.
Change committed as 276433

Powered by Google App Engine
This is Rietveld 408576698