MSE: Report decode error if FrameProcessor's append to track buffer fails

MSE: Report decode error if FrameProcessor's append to track buffer fails

LegacyFrameProcessor reported decode error if ChunkDemuxerStream
(really, if SourceBufferStream)::Append() returned false. This could be
for a variety of reasons, mostly sanity checking the timestamps.
The new FrameProcessor ignored the ChunkDemuxerStream::Append() result
and assumed success, hiding potential issues. This change makes
FrameProcessor report decode error if CDS::Append() fails.

R=acolwell@chromium.org
TEST=no media_unittest or MSE layout test regression locally on linux

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276375

[wolenetz, 2014-06-11 00:57:13]

PTAL @ PS1.
Originally, I had this as part of https://codereview.chromium.org/322273003/,
but I split it out as a prereq for that CL to help differentiate root causes if
the behavior regresses. Note that the new test introduced in that CL didn't fail
for FrameProcessor without this change applied (because the failed SBS::Append()
was ignored).

This CL is currently rebased on https://codereview.chromium.org/321233004/
(which is in CQ).

Thanks!

[acolwell GONE FROM CHROMIUM, 2014-06-11 01:22:56]

lgtm

[wolenetz, 2014-06-11 02:00:42]

Thanks for review. This CL actually doesn't depend on
https://codereview.chromium.org/321233004/ landing first.

[wolenetz, 2014-06-11 02:00:46]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2014-06-11 02:04:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wolenetz@chromium.org/324243002/1

[commit-bot: I haz the power, 2014-06-11 08:09:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-11 13:13:41]

Change committed as 276375