Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 324223004: Clean-up CSSValueKeywords.in (Closed)

Created:
6 years, 6 months ago by Julien - ping for review
Modified:
6 years, 6 months ago
Reviewers:
darktears, eae, ojan
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Visibility:
Public.

Description

Clean-up CSSValueKeywords.in This change started as a removal of stale entries in the file (mostly related to font-stretch - that was rolled out - along with some misc values). Then I looked at the file and found out that we still referred to KHTML and CSS_PROP* (none of which make any sense) so I cleaned up the comments too. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175962

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -102 lines) Patch
M Source/core/css/CSSValueKeywords.in View 31 chunks +73 lines, -102 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Julien - ping for review
6 years, 6 months ago (2014-06-11 00:45:12 UTC) #1
Julien - ping for review
Simple CSSValueKeywords.in clean-up
6 years, 6 months ago (2014-06-11 00:59:37 UTC) #2
eae
On 2014/06/11 00:59:37, Julien Chaffraix - PST wrote: > Simple CSSValueKeywords.in clean-up LGTM
6 years, 6 months ago (2014-06-11 01:02:54 UTC) #3
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 6 months ago (2014-06-11 15:57:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/324223004/1
6 years, 6 months ago (2014-06-11 15:57:34 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 16:00:23 UTC) #6
Message was sent while issue was closed.
Change committed as 175962

Powered by Google App Engine
This is Rietveld 408576698