Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 324223002: Permission bubble should not be key window when it appears. (Closed)

Created:
6 years, 6 months ago by leng
Modified:
6 years, 6 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Permission bubble should not be key window when it appears. This fixes a bug where links on the page underneath the bubble couldn't be clicked. Now, when the permission bubble first appears, the bubble will not immediately become the key window. However, if the user clicks within the bubble, it will be come key window, requiring a click within the content area to have the content area become key window again. BUG=381287 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276353

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
leng
6 years, 6 months ago (2014-06-10 22:16:35 UTC) #1
groby-ooo-7-16
lgtm
6 years, 6 months ago (2014-06-10 22:53:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/324223002/1
6 years, 6 months ago (2014-06-10 22:56:14 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 08:58:17 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 11:48:35 UTC) #5
Message was sent while issue was closed.
Change committed as 276353

Powered by Google App Engine
This is Rietveld 408576698