Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 324183002: Create an autosizing layout scope in RenderGrid. (Closed)

Created:
6 years, 6 months ago by skobes
Modified:
6 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, jfernandez, blink-reviews-rendering, zoltan1, svillar, Manuel Rego, leviw+renderwatch, eae+blinkwatch, jchaffraix+rendering, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Create an autosizing layout scope in RenderGrid. BUG=341119 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176056

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
A LayoutTests/fast/text-autosizing/grid-dbcat.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/text-autosizing/grid-dbcat-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
skobes
6 years, 6 months ago (2014-06-10 21:11:34 UTC) #1
pdr.
On 2014/06/10 21:11:34, skobes wrote: LGTM. It looks like there are several other overrides of ...
6 years, 6 months ago (2014-06-11 03:50:16 UTC) #2
skobes
On 2014/06/11 03:50:16, pdr wrote: > It looks like there are several other overrides of ...
6 years, 6 months ago (2014-06-11 21:35:18 UTC) #3
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 6 months ago (2014-06-11 21:35:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/324183002/20001
6 years, 6 months ago (2014-06-11 21:35:37 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-11 22:37:53 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:38:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15728)
6 years, 6 months ago (2014-06-11 22:38:27 UTC) #8
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 6 months ago (2014-06-12 18:27:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/324183002/20001
6 years, 6 months ago (2014-06-12 18:28:56 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-12 20:09:20 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-12 20:09:28 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 20:42:28 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11809)
6 years, 6 months ago (2014-06-12 20:42:29 UTC) #14
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 6 months ago (2014-06-12 20:44:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/324183002/20001
6 years, 6 months ago (2014-06-12 20:45:29 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 21:44:25 UTC) #17
Message was sent while issue was closed.
Change committed as 176056

Powered by Google App Engine
This is Rietveld 408576698