Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 324143002: Decouple IPC::MessageFilter from IPC::Channel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing compilation errors Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_dispatcher_host.cc
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc
index db9e37370298909b39859c34c36bd4fb252acde3..aaa632d14d1250ee7ad3486d0a63422d7909ee49 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.cc
+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc
@@ -45,7 +45,7 @@ ServiceWorkerDispatcherHost::ServiceWorkerDispatcherHost(
arraysize(kFilteredMessageClasses)),
render_process_id_(render_process_id),
message_port_message_filter_(message_port_message_filter),
- channel_ready_(false) {
+ sender_ready_(false) {
}
ServiceWorkerDispatcherHost::~ServiceWorkerDispatcherHost() {
@@ -70,9 +70,9 @@ void ServiceWorkerDispatcherHost::Init(
render_process_id_, this);
}
-void ServiceWorkerDispatcherHost::OnFilterAdded(IPC::Channel* channel) {
- BrowserMessageFilter::OnFilterAdded(channel);
- channel_ready_ = true;
+void ServiceWorkerDispatcherHost::OnFilterAdded(IPC::Sender* sender) {
+ BrowserMessageFilter::OnFilterAdded(sender);
+ sender_ready_ = true;
std::vector<IPC::Message*> messages;
pending_messages_.release(&messages);
for (size_t i = 0; i < messages.size(); ++i) {
@@ -129,7 +129,7 @@ bool ServiceWorkerDispatcherHost::OnMessageReceived(
}
bool ServiceWorkerDispatcherHost::Send(IPC::Message* message) {
- if (channel_ready_) {
+ if (sender_ready_) {
BrowserMessageFilter::Send(message);
// Don't bother passing through Send()'s result: it's not reliable.
return true;

Powered by Google App Engine
This is Rietveld 408576698