Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: content/browser/loader/resource_dispatcher_host_unittest.cc

Issue 324143002: Decouple IPC::MessageFilter from IPC::Channel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing compilation errors Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_unittest.cc
diff --git a/content/browser/loader/resource_dispatcher_host_unittest.cc b/content/browser/loader/resource_dispatcher_host_unittest.cc
index 0610a75dfba7a91ff5acf7727759ed5bf19ab6fe..75211e01540aca6e222587861adf122dcdf0b6d5 100644
--- a/content/browser/loader/resource_dispatcher_host_unittest.cc
+++ b/content/browser/loader/resource_dispatcher_host_unittest.cc
@@ -15,6 +15,7 @@
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
+#include "content/browser/browser_message_filter_peer.h"
#include "content/browser/browser_thread_impl.h"
#include "content/browser/child_process_security_policy_impl.h"
#include "content/browser/loader/cross_site_resource_handler.h"
@@ -216,9 +217,10 @@ class TestFilter : public ResourceMessageFilter {
base::Bind(&TestFilter::GetContexts, base::Unretained(this))),
resource_context_(resource_context),
canceled_(false),
- received_after_canceled_(0) {
+ received_after_canceled_(0),
+ peer_(new BrowserMessageFilterPeer(base::GetCurrentProcId())) {
ChildProcessSecurityPolicyImpl::GetInstance()->Add(child_id());
- set_peer_pid_for_testing(base::GetCurrentProcId());
+ OnFilterAddedToHost(peer_.get());
}
void set_canceled(bool canceled) { canceled_ = canceled; }
@@ -250,7 +252,7 @@ class TestFilter : public ResourceMessageFilter {
ResourceContext* resource_context_;
bool canceled_;
int received_after_canceled_;
-
+ scoped_ptr<BrowserMessageFilterPeer> peer_;
DISALLOW_COPY_AND_ASSIGN(TestFilter);
};
@@ -1186,7 +1188,7 @@ TEST_F(ResourceDispatcherHostTest, DeletedFilterDetached) {
host_.GetURLRequest(GlobalRequestID(filter_->child_id(), 2)));
DCHECK_EQ(filter_.get(), info_prefetch->filter());
DCHECK_EQ(filter_.get(), info_ping->filter());
- filter_->OnChannelClosing();
+ filter_->OnSenderClosing();
info_prefetch->filter_.reset();
info_ping->filter_.reset();
@@ -1231,7 +1233,7 @@ TEST_F(ResourceDispatcherHostTest, DeletedFilterDetachedRedirect) {
GlobalRequestID global_request_id(filter_->child_id(), 1);
ResourceRequestInfoImpl* info = ResourceRequestInfoImpl::ForRequest(
host_.GetURLRequest(global_request_id));
- info->filter_->OnChannelClosing();
+ info->filter_->OnSenderClosing();
info->filter_.reset();
// From the renderer's perspective, the request was cancelled.
@@ -2807,7 +2809,7 @@ TEST_F(ResourceDispatcherHostTest, ReleaseTemporiesOnProcessExit) {
filter_->child_id(), file_path));
// Let the process die.
- filter_->OnChannelClosing();
+ filter_->OnSenderClosing();
base::RunLoop().RunUntilIdle();
// The file is no longer readable to the child and has been deleted.

Powered by Google App Engine
This is Rietveld 408576698