Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/renderer/media/webrtc_logging_message_filter.cc

Issue 324143002: Decouple IPC::MessageFilter from IPC::Channel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing compilation errors Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/media/webrtc_logging_message_filter.cc
diff --git a/chrome/renderer/media/webrtc_logging_message_filter.cc b/chrome/renderer/media/webrtc_logging_message_filter.cc
index 83ad4d659718ee28d2894fda7f2cd60a6b3c7f68..7bc000cda1abeea0517581d9f0d67e07b778f73f 100644
--- a/chrome/renderer/media/webrtc_logging_message_filter.cc
+++ b/chrome/renderer/media/webrtc_logging_message_filter.cc
@@ -14,7 +14,7 @@ WebRtcLoggingMessageFilter::WebRtcLoggingMessageFilter(
const scoped_refptr<base::MessageLoopProxy>& io_message_loop)
: io_message_loop_(io_message_loop),
log_message_delegate_(NULL),
- channel_(NULL) {
+ sender_(NULL) {
// May be null in a browsertest using MockRenderThread.
if (io_message_loop_) {
io_message_loop_->PostTask(
@@ -39,20 +39,20 @@ bool WebRtcLoggingMessageFilter::OnMessageReceived(
return handled;
}
-void WebRtcLoggingMessageFilter::OnFilterAdded(IPC::Channel* channel) {
+void WebRtcLoggingMessageFilter::OnFilterAdded(IPC::Sender* sender) {
DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
- channel_ = channel;
+ sender_ = sender;
}
void WebRtcLoggingMessageFilter::OnFilterRemoved() {
DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
- channel_ = NULL;
+ sender_ = NULL;
log_message_delegate_->OnFilterRemoved();
}
-void WebRtcLoggingMessageFilter::OnChannelClosing() {
+void WebRtcLoggingMessageFilter::OnSenderClosing() {
DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
- channel_ = NULL;
+ sender_ = NULL;
log_message_delegate_->OnFilterRemoved();
}
@@ -85,10 +85,10 @@ void WebRtcLoggingMessageFilter::OnStopLogging() {
void WebRtcLoggingMessageFilter::Send(IPC::Message* message) {
DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
- if (!channel_) {
- DLOG(ERROR) << "IPC channel not available.";
+ if (!sender_) {
+ DLOG(ERROR) << "IPC sender not available.";
delete message;
} else {
- channel_->Send(message);
+ sender_->Send(message);
}
}

Powered by Google App Engine
This is Rietveld 408576698