Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: content/browser/dom_storage/dom_storage_message_filter.cc

Issue 324143002: Decouple IPC::MessageFilter from IPC::Channel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Landing Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/dom_storage/dom_storage_message_filter.h" 5 #include "content/browser/dom_storage/dom_storage_message_filter.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/strings/nullable_string16.h" 9 #include "base/strings/nullable_string16.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 29 matching lines...) Expand all
40 } 40 }
41 41
42 void DOMStorageMessageFilter::UninitializeInSequence() { 42 void DOMStorageMessageFilter::UninitializeInSequence() {
43 // TODO(michaeln): Restore this DCHECK once crbug/166470 and crbug/164403 43 // TODO(michaeln): Restore this DCHECK once crbug/166470 and crbug/164403
44 // are resolved. 44 // are resolved.
45 // DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::IO)); 45 // DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::IO));
46 context_->RemoveEventObserver(this); 46 context_->RemoveEventObserver(this);
47 host_.reset(); 47 host_.reset();
48 } 48 }
49 49
50 void DOMStorageMessageFilter::OnFilterAdded(IPC::Channel* channel) { 50 void DOMStorageMessageFilter::OnFilterAdded(IPC::Sender* sender) {
51 context_->task_runner()->PostShutdownBlockingTask( 51 context_->task_runner()->PostShutdownBlockingTask(
52 FROM_HERE, 52 FROM_HERE,
53 DOMStorageTaskRunner::PRIMARY_SEQUENCE, 53 DOMStorageTaskRunner::PRIMARY_SEQUENCE,
54 base::Bind(&DOMStorageMessageFilter::InitializeInSequence, this)); 54 base::Bind(&DOMStorageMessageFilter::InitializeInSequence, this));
55 } 55 }
56 56
57 void DOMStorageMessageFilter::OnFilterRemoved() { 57 void DOMStorageMessageFilter::OnFilterRemoved() {
58 context_->task_runner()->PostShutdownBlockingTask( 58 context_->task_runner()->PostShutdownBlockingTask(
59 FROM_HERE, 59 FROM_HERE,
60 DOMStorageTaskRunner::PRIMARY_SEQUENCE, 60 DOMStorageTaskRunner::PRIMARY_SEQUENCE,
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 params.connection_id = connection_dispatching_message_for_; 217 params.connection_id = connection_dispatching_message_for_;
218 params.key = key; 218 params.key = key;
219 params.new_value = new_value; 219 params.new_value = new_value;
220 params.old_value = old_value; 220 params.old_value = old_value;
221 params.namespace_id = alias_namespace_id; 221 params.namespace_id = alias_namespace_id;
222 Send(new DOMStorageMsg_Event(params)); 222 Send(new DOMStorageMsg_Event(params));
223 } 223 }
224 } 224 }
225 225
226 } // namespace content 226 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698