Chromium Code Reviews
Help | Chromium Project | Sign in
(64)

Issue 3241008: Silencing a couple of dchecks that occur when running the debug version of th... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by tommi
Modified:
4 years ago
Reviewers:
robertshield
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Silencing a couple of dchecks that occur when running the debug version of the *TabCrashReload* tests. TEST=Run debug versions of *TabCrashReload* tests. There should be no more dchecks. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58067

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M chrome_frame/chrome_active_document.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 5 (0 generated)
tommi
4 years, 9 months ago (2010-08-31 19:57:43 UTC) #1
robertshield
LGTM http://codereview.chromium.org/3241008/diff/1/2 File chrome_frame/chrome_frame_automation.cc (right): http://codereview.chromium.org/3241008/diff/1/2#newcode620 chrome_frame/chrome_frame_automation.cc:620: hr = security_manager_.CreateInstance(CLSID_InternetSecurityManager); microscopic nit: I don't like ...
4 years, 9 months ago (2010-08-31 20:12:08 UTC) #2
tommi
Regarding your second comment, I found a better way to avoid that check. I have ...
4 years, 9 months ago (2010-08-31 20:24:12 UTC) #3
tommi
Regarding your second comment, I found a better way to avoid that check. I have ...
4 years, 9 months ago (2010-08-31 20:24:19 UTC) #4
robertshield
4 years, 9 months ago (2010-08-31 20:38:47 UTC) #5
On 2010/08/31 20:24:19, tommi wrote:
> Regarding your second comment, I found a better way to avoid that check. I
have
> reverted that file and add another instead.  Please take a look.

Looks Grotesque To Most
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be