Remove unused 'deepCopy' parameter

Remove unused 'deepCopy' parameter

This is split out of https://codereview.chromium.org/316063005/ for clarity. Keeping in mind that SkPicture::FakeEndRecording is now only called from SkPictureRecorder, its deepCopy parameter is no longer necessary. This is b.c., given the new Picture recording semantics (where SkPictures can no longer be actively recording), cloning for thread safety only happens when an SkPicturePlayback has already been allocated (i.e., it happens in the SkPicturePlayback copy constructor.

Committed: https://skia.googlesource.com/skia/+/6de27127c4d50ef90b5435aefaeef47fa84b819d

[reed1, 2014-06-10 14:23:17]

lgtm

[robertphillips, 2014-06-10 14:58:00]

The CQ bit was checked by robertphillips@google.com

[scroggo, 2014-06-10 14:58:04]

lgtm

https://codereview.chromium.org/324093003/diff/1/src/core/SkPicture.cpp
File src/core/SkPicture.cpp (right):

https://codereview.chromium.org/324093003/diff/1/src/core/SkPicture.cpp#newco...
src/core/SkPicture.cpp:136: SkPicturePlayback* SkPicture::FakeEndRecording(const
SkPicture* resourceSrc,
As I asked in https://codereview.chromium.org/316063005/ , does it make sense to
move this into its only caller?

[commit-bot: I haz the power, 2014-06-10 14:58:35]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/robertphillips@google.com/324093003/1

[robertphillips, 2014-06-10 15:00:10]

https://codereview.chromium.org/324093003/diff/1/src/core/SkPicture.cpp
File src/core/SkPicture.cpp (right):

https://codereview.chromium.org/324093003/diff/1/src/core/SkPicture.cpp#newco...
src/core/SkPicture.cpp:136: SkPicturePlayback* SkPicture::FakeEndRecording(const
SkPicture* resourceSrc,
This entry point is going away entirely (replaced by a new SkPicture
constructor) so I don't think it is worth moving right now.

[scroggo, 2014-06-10 15:00:44]

https://codereview.chromium.org/324093003/diff/1/src/core/SkPicture.cpp
File src/core/SkPicture.cpp (right):

https://codereview.chromium.org/324093003/diff/1/src/core/SkPicture.cpp#newco...
src/core/SkPicture.cpp:136: SkPicturePlayback* SkPicture::FakeEndRecording(const
SkPicture* resourceSrc,
On 2014/06/10 15:00:09, robertphillips wrote:
> This entry point is going away entirely (replaced by a new SkPicture
> constructor) so I don't think it is worth moving right now.

sgtm. Thanks for the explanation.

[commit-bot: I haz the power, 2014-06-10 16:23:11]

Change committed as 6de27127c4d50ef90b5435aefaeef47fa84b819d