Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 324083007: Try 1 at rebaseline (Closed)

Created:
6 years, 6 months ago by kelvinly
Modified:
6 years, 6 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M bench/gen_bench_expectations.py View 1 chunk +6 lines, -5 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
kelvinly
Using two standard deviations from the average for expectations
6 years, 6 months ago (2014-06-10 19:53:58 UTC) #1
benchen
LGTM. Be prepared to make many iterations from here. Thanks! You may use the rebase.py ...
6 years, 6 months ago (2014-06-10 19:59:23 UTC) #2
benchen
Oh, and for CL descriptions, since we also have "gm rebaseline", it's clearer to use ...
6 years, 6 months ago (2014-06-10 20:00:29 UTC) #3
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 6 months ago (2014-06-10 20:19:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/324083007/1
6 years, 6 months ago (2014-06-10 20:19:56 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 22:05:14 UTC) #6
Message was sent while issue was closed.
Change committed as b6f431612fb6bcf86217f9136846b00ab57efa5c

Powered by Google App Engine
This is Rietveld 408576698