Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 324083006: Update two obsolete RFC references. (Closed)

Created:
6 years, 6 months ago by Bence
Modified:
6 years, 6 months ago
Reviewers:
cbentzel
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Update two obsolete RFC references. BUG=382120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276412

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix msg#2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M net/http/http_byte_range.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_util.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Bence
6 years, 6 months ago (2014-06-10 19:55:22 UTC) #1
cbentzel
LGTM % nits https://codereview.chromium.org/324083006/diff/1/net/http/http_byte_range.h File net/http/http_byte_range.h (right): https://codereview.chromium.org/324083006/diff/1/net/http/http_byte_range.h#newcode17 net/http/http_byte_range.h:17: // http://tools.ietf.org/html/rfc7233#section-2.1 Nit: use https rather ...
6 years, 6 months ago (2014-06-10 19:55:42 UTC) #2
Bence
6 years, 6 months ago (2014-06-10 20:03:35 UTC) #3
cbentzel
On 2014/06/10 20:03:35, bnc wrote: LGMT
6 years, 6 months ago (2014-06-10 20:07:20 UTC) #4
cbentzel
On 2014/06/10 20:07:20, cbentzel wrote: > On 2014/06/10 20:03:35, bnc wrote: > > LGMT LGTM ...
6 years, 6 months ago (2014-06-10 20:07:26 UTC) #5
Bence
The CQ bit was checked by bnc@chromium.org
6 years, 6 months ago (2014-06-10 20:14:14 UTC) #6
Bence
The CQ bit was unchecked by bnc@chromium.org
6 years, 6 months ago (2014-06-10 20:14:15 UTC) #7
Bence
The CQ bit was checked by bnc@chromium.org
6 years, 6 months ago (2014-06-10 20:18:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bnc@chromium.org/324083006/20001
6 years, 6 months ago (2014-06-10 20:23:34 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 11:10:56 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 15:41:03 UTC) #11
Message was sent while issue was closed.
Change committed as 276412

Powered by Google App Engine
This is Rietveld 408576698