Source/core/rendering/RenderFlexibleBox.cpp - Issue 324073003: Flex box word-wrap is not adhering to spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFlexibleBox.cpp

Issue 324073003: Flex box word-wrap is not adhering to spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderFlexibleBox.cpp

diff --git a/Source/core/rendering/RenderFlexibleBox.cpp b/Source/core/rendering/RenderFlexibleBox.cpp

index 62dfee372307b28119fa28e0ee64d50dc7fef3a5..37a15ceae4b4436b5d720d4e7de5316eeddaa926 100644

--- a/Source/core/rendering/RenderFlexibleBox.cpp

+++ b/Source/core/rendering/RenderFlexibleBox.cpp

@@ -316,7 +316,7 @@ void RenderFlexibleBox::repositionLogicalHeightDependentFlexItems(Vector<LineCon

// If we have a single line flexbox, the line height is all the available space.

tony 2014/06/10 16:30:21 Please update this comment.

harpreet.sk 2014/06/11 08:13:16 Done.

// For flex-direction: row, this means we need to use the height, so we do this after calling updateLogicalHeight.

- if (!isMultiline() && lineContexts.size() == 1)

+ if (lineContexts.size() == 1)

lineContexts[0].crossAxisExtent = crossAxisContentExtent();

alignChildren(lineContexts);