Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 324073003: Flex box word-wrap is not adhering to spec (Closed)

Created:
6 years, 6 months ago by harpreet.sk
Modified:
6 years, 6 months ago
CC:
blink-reviews, cbiesinger, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Flex box word-wrap is not adhering to spec The items that are set to flex-wrap and have a single flex line currently has their cross size adjusted according to the max of the items cross size. According to the specification section 9.4 number 8 point, it states that: If the flex container has only one flex line (_even if it’s a multi-line flex container_) and has a definite cross size the cross size of the flex line is the flex container’s inner cross size. link: http://www.w3.org/TR/2014/WD-css-flexbox-1-20140325/#cross-sizing This patch fixes this bug by removing the condtion that checks if it's a multiline container or not and based on that set flex line cross size. Bug=362848 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176000

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addresses changes asked in patch set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -6 lines) Patch
A LayoutTests/css3/flexbox/flexbox-wordwrap.html View 1 1 chunk +108 lines, -0 lines 1 comment Download
A LayoutTests/css3/flexbox/flexbox-wordwrap-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/css3/flexbox/multiline-align-content.html View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
harpreet.sk
ptal
6 years, 6 months ago (2014-06-10 15:12:48 UTC) #1
tony
https://codereview.chromium.org/324073003/diff/1/LayoutTests/css3/flexbox/flexbox-wordwrap.html File LayoutTests/css3/flexbox/flexbox-wordwrap.html (right): https://codereview.chromium.org/324073003/diff/1/LayoutTests/css3/flexbox/flexbox-wordwrap.html#newcode50 LayoutTests/css3/flexbox/flexbox-wordwrap.html:50: <div class="flex" style="flex-wrap:wrap;"> There should be tests for column ...
6 years, 6 months ago (2014-06-10 16:30:21 UTC) #2
harpreet.sk
Thanks tony for your comments. I have made the changes and uploaded a new patch. ...
6 years, 6 months ago (2014-06-11 08:13:17 UTC) #3
tony
LGTM
6 years, 6 months ago (2014-06-11 16:16:33 UTC) #4
harpreet.sk
The CQ bit was checked by harpreet.sk@samsung.com
6 years, 6 months ago (2014-06-11 16:36:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/324073003/20001
6 years, 6 months ago (2014-06-11 16:36:24 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-11 17:32:41 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 17:35:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7453)
6 years, 6 months ago (2014-06-11 17:35:56 UTC) #9
harpreet.sk
blink presubmit is getting failed. Missing LGTM from owner. @ojan can you please give lgtm
6 years, 6 months ago (2014-06-12 06:09:01 UTC) #10
ojan
lgtm https://codereview.chromium.org/324073003/diff/20001/LayoutTests/css3/flexbox/flexbox-wordwrap.html File LayoutTests/css3/flexbox/flexbox-wordwrap.html (right): https://codereview.chromium.org/324073003/diff/20001/LayoutTests/css3/flexbox/flexbox-wordwrap.html#newcode3 LayoutTests/css3/flexbox/flexbox-wordwrap.html:3: <head> We usually leave out the html, head ...
6 years, 6 months ago (2014-06-12 06:20:10 UTC) #11
harpreet.sk
The CQ bit was checked by harpreet.sk@samsung.com
6 years, 6 months ago (2014-06-12 06:24:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/324073003/20001
6 years, 6 months ago (2014-06-12 06:25:44 UTC) #13
harpreet.sk
The CQ bit was unchecked by harpreet.sk@samsung.com
6 years, 6 months ago (2014-06-12 06:25:55 UTC) #14
harpreet.sk
The CQ bit was checked by harpreet.sk@samsung.com
6 years, 6 months ago (2014-06-12 06:25:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/324073003/20001
6 years, 6 months ago (2014-06-12 06:26:39 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 06:30:44 UTC) #17
Message was sent while issue was closed.
Change committed as 176000

Powered by Google App Engine
This is Rietveld 408576698