Oilpan: Switch RefCountedGarbageCollected to GarbageCollectedFinalized for Node.

Oilpan: Switch RefCountedGarbageCollected to GarbageCollectedFinalized for Node.

- Source/core/dom/Node.h
  Replace TreeSharedWillBeRefCountedGarbageCollected with
  TreeSharedWillBeGarbageCollectedFinalized.
- Source/platform/heap/Handle.h
  Replace TreeSharedWillBeRefCountedGarbageCollected with
  TreeSharedWillBeGarbageCollectedFinalized.
- public/platform/WebPrivatePtr.h
  Introduce PtrStorageImpl<T, GarbageCollectedLifetime>::
  assign(const RawPtr<U>&) because matching RawPtr<U> value with
  assign(const RawPtr<T>&) and assign(T*) are ambiguous.

Leftover RefPtr:
- Source/core/dom/StyleEngine.cpp
- Source/core/dom/StyleEngine.h
- Source/core/fetch/FontResource.h

Remove |using| directives for T::ref and T::deref if ENABLE(OILPAN)
- Source/core/dom/Document.h
- Source/core/html/HTMLFormControlElement.h
- Source/core/html/HTMLObjectElement.h
- Source/core/svg/SVGSVGElement.h
- Source/core/svg/SVGViewElement.h

Simple replacement of adoptRefWillBeRefCountedGarbageCollected:
- Source/core/dom/Attr.cpp
- Source/core/dom/CDATASection.cpp
- Source/core/dom/Comment.cpp
- Source/core/dom/Document.h
- Source/core/dom/DocumentFragment.cpp
- Source/core/dom/DocumentType.h
- Source/core/dom/Element.cpp
- Source/core/dom/Element.h
- Source/core/dom/ProcessingInstruction.cpp
- Source/core/dom/PseudoElement.h
- Source/core/dom/TemplateContentDocumentFragment.h
- Source/core/dom/Text.cpp
- Source/core/dom/XMLDocument.h
- Source/core/dom/shadow/ShadowRoot.h
- Source/core/html/HTMLAnchorElement.cpp
- Source/core/html/HTMLAppletElement.cpp
- Source/core/html/HTMLAudioElement.cpp
- Source/core/html/HTMLButtonElement.cpp
- Source/core/html/HTMLDataListElement.cpp
- Source/core/html/HTMLDetailsElement.cpp
- Source/core/html/HTMLDocument.h
- Source/core/html/HTMLEmbedElement.cpp
- Source/core/html/HTMLFieldSetElement.cpp
- Source/core/html/HTMLFormElement.cpp
- Source/core/html/HTMLImageElement.cpp
- Source/core/html/HTMLInputElement.cpp
- Source/core/html/HTMLKeygenElement.cpp
- Source/core/html/HTMLLinkElement.cpp
- Source/core/html/HTMLMarqueeElement.cpp
- Source/core/html/HTMLMeterElement.cpp
- Source/core/html/HTMLObjectElement.cpp
- Source/core/html/HTMLOptionElement.cpp
- Source/core/html/HTMLOutputElement.cpp
- Source/core/html/HTMLProgressElement.cpp
- Source/core/html/HTMLScriptElement.cpp
- Source/core/html/HTMLSelectElement.cpp
- Source/core/html/HTMLStyleElement.cpp
- Source/core/html/HTMLSummaryElement.cpp
- Source/core/html/HTMLTextAreaElement.cpp
- Source/core/html/HTMLUnknownElement.h
- Source/core/html/HTMLVideoElement.cpp
- Source/core/html/HTMLViewSourceDocument.h
- Source/core/html/ImageDocument.h
- Source/core/html/MediaDocument.h
- Source/core/html/PluginDocument.h
- Source/core/html/TextDocument.h
- Source/core/html/forms/TextFieldInputType.cpp
- Source/core/html/shadow/ClearButtonElement.cpp
- Source/core/html/shadow/DateTimeEditElement.cpp
- Source/core/html/shadow/DateTimeFieldElements.cpp
- Source/core/html/shadow/DetailsMarkerControl.h
- Source/core/html/shadow/MediaControlElements.cpp
- Source/core/html/shadow/MediaControls.cpp
- Source/core/html/shadow/MeterShadowElement.cpp
- Source/core/html/shadow/PickerIndicatorElement.cpp
- Source/core/html/shadow/SliderThumbElement.cpp
- Source/core/html/shadow/SpinButtonElement.cpp
- Source/core/html/shadow/TextControlInnerElements.cpp
- Source/core/html/track/vtt/VTTCue.h
- Source/core/html/track/vtt/VTTElement.cpp
- Source/core/loader/SinkDocument.h
- Source/core/svg/SVGAnimateElement.cpp
- Source/core/svg/SVGScriptElement.cpp
- Source/core/svg/SVGScriptElement.cpp
- Source/core/svg/SVGUseElement.cpp

BUG=357163
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176019

[tkent, 2014-06-11 04:35:36]

Please review this.
This is large, but it's trivial.
It depends on https://codereview.chromium.org/294053006/ and the
MediaElementAudioSourceNode.h change of Patch Set 1 should be removed before
landing.

[haraken, 2014-06-11 04:47:55]

We get here! LGTM.

Let's land this after Ian lands the HTMLMediaElement change.

https://codereview.chromium.org/324073002/diff/40001/Source/core/dom/Node.h
File Source/core/dom/Node.h (right):

https://codereview.chromium.org/324073002/diff/40001/Source/core/dom/Node.h#n...
Source/core/dom/Node.h:110: class Node : public EventTarget, public
ScriptWrappable, public TreeSharedWillBeGarbageCollectedFinalized<Node> {

Ian: This is a question not related to this CL, but are we ready to replace
RefCountedGarbageCollected of classes that derive EventTarget with
GarbageCollectedFinalized?

https://codereview.chromium.org/324073002/diff/40001/Source/core/dom/Node.h#n...
Source/core/dom/Node.h:110: class Node : public EventTarget, public
ScriptWrappable, public TreeSharedWillBeGarbageCollectedFinalized<Node> {

GarbageCollectedFinalized should be the left-most class.

However, I'm a bit confused:

- Why was the previous code working with having RefCountedGarbageCollected at
not the left-most class?

- Why doesn't the plugin detect the error?

[haraken, 2014-06-11 04:59:04]

https://codereview.chromium.org/324073002/diff/40001/Source/core/dom/Node.h
File Source/core/dom/Node.h (right):

https://codereview.chromium.org/324073002/diff/40001/Source/core/dom/Node.h#n...
Source/core/dom/Node.h:110: class Node : public EventTarget, public
ScriptWrappable, public TreeSharedWillBeGarbageCollectedFinalized<Node> {

On the other hand, I remembered that TreeShared must be the right-most class,
because we want to align TreeShared::m_refCount (32 bit interger) and
Node::m_nodeFlags (32 bit interger) into one 64 bit slot. If we put the
TreeShared at the left-most class, it will increase sizeof(Node) by 8 byte.

So you'll need to do:

// Some comment
#if ENABLE(OILPAN)
class Node : public GarbageCollectedFinalized<Node>, public EventTarget, public
ScriptWrappable {
#else
class Node : public EventTarget, public ScriptWrappable, public TreeShared<Node>
{
#endif

[Mads Ager (chromium), 2014-06-11 05:48:23]

LGTM! :)

https://codereview.chromium.org/324073002/diff/40001/Source/core/dom/Node.h
File Source/core/dom/Node.h (right):

https://codereview.chromium.org/324073002/diff/40001/Source/core/dom/Node.h#n...
Source/core/dom/Node.h:110: class Node : public EventTarget, public
ScriptWrappable, public TreeSharedWillBeGarbageCollectedFinalized<Node> {
On 2014/06/11 04:47:55, haraken wrote:
> 
> Ian: This is a question not related to this CL, but are we ready to replace
> RefCountedGarbageCollected of classes that derive EventTarget with
> GarbageCollectedFinalized?

Yes, Ian's change to move all EventTargets to the heap and use tracing instead
of ref counting for them has landed, so this is good.

https://codereview.chromium.org/324073002/diff/40001/Source/core/dom/Node.h#n...
Source/core/dom/Node.h:110: class Node : public EventTarget, public
ScriptWrappable, public TreeSharedWillBeGarbageCollectedFinalized<Node> {
On 2014/06/11 04:47:55, haraken wrote:
> 
> GarbageCollectedFinalized should be the left-most class.
> 
> However, I'm a bit confused:
> 
> - Why was the previous code working with having RefCountedGarbageCollected at
> not the left-most class?

It seems that we got lucky that the layout of the object generated by the
compiler is such that a Node pointer always points to the start of the object
even though GarbageCollectedFinalized is not inherited as the left-most base
class. We should move it around as you suggest Haraken so that we are sure that
it becomes the left-most base class.

> - Why doesn't the plugin detect the error?

Good question. We should update the plugin to catch this.

[tkent, 2014-06-12 10:12:50]

https://codereview.chromium.org/324073002/diff/40001/Source/core/dom/Node.h
File Source/core/dom/Node.h (right):

https://codereview.chromium.org/324073002/diff/40001/Source/core/dom/Node.h#n...
Source/core/dom/Node.h:110: class Node : public EventTarget, public
ScriptWrappable, public TreeSharedWillBeGarbageCollectedFinalized<Node> {
On 2014/06/11 04:59:04, haraken wrote:
> 
> On the other hand, I remembered that TreeShared must be the right-most class,
> because we want to align TreeShared::m_refCount (32 bit interger) and
> Node::m_nodeFlags (32 bit interger) into one 64 bit slot. If we put the
> TreeShared at the left-most class, it will increase sizeof(Node) by 8 byte.
> 
> So you'll need to do:
> 
> // Some comment
> #if ENABLE(OILPAN)
> class Node : public GarbageCollectedFinalized<Node>, public EventTarget,
public
> ScriptWrappable {
> #else
> class Node : public EventTarget, public ScriptWrappable, public
TreeShared<Node>
> {
> #endif

Done.

[tkent, 2014-06-12 10:14:48]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-06-12 10:15:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/324073002/80001

[wibling-chromium, 2014-06-12 10:39:56]

lgtm

[commit-bot: I haz the power, 2014-06-12 11:20:34]

Change committed as 176019