Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 324023002: Mojo: cleanup redirect handling for network service. (Closed)

Created:
6 years, 6 months ago by darin (slow to review)
Modified:
6 years, 6 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: cleanup redirect handling for network service. Eliminate redirects field. Leave it up to clients to log the redirect chain if so desired. It is not worth sending this list over the pipe each time we see a redirect. Add support for "follow_redirects" request parameter. Rename it with an "auto_" suffix for greater clarity. R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276051

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -15 lines) Patch
M mojo/examples/wget/wget.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/network/url_loader_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/url_loader_impl.cc View 1 4 chunks +20 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/network/url_loader.mojom View 1 2 chunks +36 lines, -10 lines 0 comments Download
M mojo/shell/dynamic_service_loader.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
darin (slow to review)
6 years, 6 months ago (2014-06-10 06:33:04 UTC) #1
DaveMoore
lgtm
6 years, 6 months ago (2014-06-10 14:14:29 UTC) #2
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 6 months ago (2014-06-10 15:03:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/324023002/1
6 years, 6 months ago (2014-06-10 15:05:53 UTC) #4
darin (slow to review)
6 years, 6 months ago (2014-06-10 16:29:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r276051 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698