Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 324003002: Add a UMA histogram for type of web font usage (Closed)

Created:
6 years, 6 months ago by Kunihiko Sakamoto
Modified:
6 years, 6 months ago
Reviewers:
dglazkov, bashi
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin
Visibility:
Public.

Description

Add a UMA histogram for type of web font usage This patch adds WebFont.PackageFormat histogram that tracks the usage of different format of web fonts. It records container format of font file; both TrueType fonts and OpenType fonts are recorded as SFNT format. If a font didn't pass OTS sanitization, it's recoreded as Unknown. BUG=380988 TEST=manually tested with chrome://histograms Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175991

Patch Set 1 #

Patch Set 2 : Rebase, and make PackageFormatUnknown the first bucket #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
M Source/core/fetch/FontResource.cpp View 1 3 chunks +38 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Kunihiko Sakamoto
6 years, 6 months ago (2014-06-10 06:31:12 UTC) #1
bashi
On 2014/06/10 06:31:12, Kunihiko Sakamoto wrote: Non-owner LGTM.
6 years, 6 months ago (2014-06-10 08:35:39 UTC) #2
dglazkov
lgtm
6 years, 6 months ago (2014-06-10 15:26:22 UTC) #3
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org
6 years, 6 months ago (2014-06-11 02:34:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/324003002/1
6 years, 6 months ago (2014-06-11 02:34:43 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-11 03:44:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 04:27:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11542)
6 years, 6 months ago (2014-06-11 04:27:18 UTC) #8
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org
6 years, 6 months ago (2014-06-12 01:39:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/324003002/20001
6 years, 6 months ago (2014-06-12 01:39:39 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 05:43:25 UTC) #11
Message was sent while issue was closed.
Change committed as 175991

Powered by Google App Engine
This is Rietveld 408576698