Source/web/WebSurroundingText.cpp - Issue 323983006: Make SurroundingText work for a Range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebSurroundingText.cpp

Issue 323983006: Make SurroundingText work for a Range. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: apply review comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebSurroundingText.cpp

diff --git a/Source/web/WebSurroundingText.cpp b/Source/web/WebSurroundingText.cpp

index 2715cf57e0d84c687fffc9fb7bda3313ef2a001e..58383dcdf89ddcb3c6455ad813fe0d1384c26c1e 100644

--- a/Source/web/WebSurroundingText.cpp

+++ b/Source/web/WebSurroundingText.cpp

@@ -55,7 +55,8 @@ WebString WebSurroundingText::textContent() const

size_t WebSurroundingText::hitOffsetInTextContent() const

{

- return m_private->positionOffsetInContent();

+ ASSERT(m_private->startOffsetInContent() == m_private->endOffsetInContent());

+ return m_private->startOffsetInContent();

}

WebRange WebSurroundingText::rangeFromContentOffsets(size_t startOffsetInContent, size_t endOffsetInContent)

« no previous file with comments | « Source/core/editing/SurroundingTextTest.cpp ('k') | no next file » | no next file with comments »