Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 323963002: Remove old functions in the process of renaming WebFontFamily to WebFallbackFont (Closed)

Created:
6 years, 6 months ago by Dominik Röttsches
Modified:
6 years, 6 months ago
CC:
abarth-chromium, blink-reviews, Rik, danakj, dglazkov+blink, krit, jamesr, jbroman, pdr., rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@ren_step1
Visibility:
Public.

Description

Remove old functions in the process of renaming WebFontFamily to WebFallbackFont Second blink side change, part 3 of the series in total. BUG=382411 R=eae,behdad,tkent Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -102 lines) Patch
M Source/platform/exported/linux/WebFontInfo.cpp View 1 chunk +0 lines, -77 lines 0 comments Download
M Source/platform/fonts/linux/FontCacheLinux.cpp View 2 chunks +8 lines, -15 lines 0 comments Download
M public/platform/linux/WebFontInfo.h View 1 chunk +0 lines, -3 lines 0 comments Download
M public/platform/linux/WebSandboxSupport.h View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Dominik Röttsches
6 years, 6 months ago (2014-06-09 22:01:20 UTC) #1
eae
LGTM
6 years, 6 months ago (2014-06-09 22:08:46 UTC) #2
eae
+abarth OWNERS approval needed for public/
6 years, 6 months ago (2014-06-09 22:09:15 UTC) #3
eae
Actually adding abarth this time.
6 years, 6 months ago (2014-06-09 22:09:32 UTC) #4
abarth-chromium
public/ LGTM
6 years, 6 months ago (2014-06-09 23:59:09 UTC) #5
Dominik Röttsches
Thanks for your reviews, Adam & Emil. Removing WebFontFamily.h should be part of this patch ...
6 years, 6 months ago (2014-06-10 09:22:43 UTC) #6
Dominik Röttsches
> Removing WebFontFamily.h should be part of this patch as well, instead of doing > ...
6 years, 6 months ago (2014-06-16 12:13:31 UTC) #7
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 6 months ago (2014-06-16 12:13:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/323963002/1
6 years, 6 months ago (2014-06-16 12:14:43 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 13:19:32 UTC) #10
Message was sent while issue was closed.
Change committed as 176207

Powered by Google App Engine
This is Rietveld 408576698