Support for recording registered LSPs

chrome/common/safe_browsing/csd.proto

Index: chrome/common/safe_browsing/csd.proto
diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto
index a04147a28a31b27c9318aded6e623e6a3e4b0422..cb248125bb775731bf87a04313631b7997687712 100644
--- a/chrome/common/safe_browsing/csd.proto
+++ b/chrome/common/safe_browsing/csd.proto
@@ -110,7 +110,7 @@ message ClientMalwareRequest {
     required string url = 2;
     optional string method = 3;
     optional string referrer = 4;
-    // Resource type, the int value is a direct cast from the Type enum 
+    // Resource type, the int value is a direct cast from the Type enum
     // of ResourceType class defined in //src/webkit/commom/resource_type.h
     optional int32 resource_type = 5;
   }
@@ -380,7 +380,7 @@ message ClientIncidentReport {
     optional Machine machine = 2;
     message Process {
       optional string version = 1;
-      repeated string dlls = 2;
+      repeated string OBSOLETE_dlls = 2;
       message Patch {
         optional string function = 1;
         optional string target_dll = 2;
@@ -397,6 +397,17 @@ message ClientIncidentReport {
       }
       optional Channel chrome_update_channel = 5;
       optional int64 uptime_msec = 6;
+      message Dll {
+        enum Feature {
+          UNKNOWN = 0;
+          LSP = 1;
+        }
+        optional string path = 1;
+        optional uint32 base_address = 2;

[mattm, 2014/06/17 01:28:18]

what about 64bit chrome?

[grt (UTC plus 2), 2014/06/17 10:22:05]

AddressOfEntryPoint (base_address) and SizeOfCode (length) are both DWORDs in
the PE image headers for 32-bit and 64-bit images (see
http://msdn.microsoft.com/en-us/gg463119.aspx).

[grt (UTC plus 2), 2014/06/17 13:10:06]

Ah, but now I see that the base_address isn't AddressOfEntryPoint, but is the
location in memory. This should be a uint64. Apologies for the misdirection,
Patrick.

[pmonette_google.com, 2014/06/17 17:48:22]

Done.

+        optional uint32 length = 3;
+        repeated Feature feature = 4;
+      }
+      repeated Dll dll = 9;

[grt (UTC plus 2), 2014/06/16 20:30:38]

note to matt: i've asked patrick to use 9 here since i'm adding 7 and 8 in
another CL elsewhere.

     }
     optional Process process = 3;
   }