Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2718)

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 323953002: Support for recording registered LSPs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@grt
Patch Set: Addressing more comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/safe_browsing/csd.proto
diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto
index a04147a28a31b27c9318aded6e623e6a3e4b0422..6e9572c0b416d446df76e8d3c648e13346ffacbd 100644
--- a/chrome/common/safe_browsing/csd.proto
+++ b/chrome/common/safe_browsing/csd.proto
@@ -110,7 +110,7 @@ message ClientMalwareRequest {
required string url = 2;
optional string method = 3;
optional string referrer = 4;
- // Resource type, the int value is a direct cast from the Type enum
+ // Resource type, the int value is a direct cast from the Type enum
// of ResourceType class defined in //src/webkit/commom/resource_type.h
optional int32 resource_type = 5;
}
@@ -380,7 +380,7 @@ message ClientIncidentReport {
optional Machine machine = 2;
message Process {
optional string version = 1;
- repeated string dlls = 2;
+ repeated string OBSOLETE_dlls = 2;
message Patch {
optional string function = 1;
optional string target_dll = 2;
@@ -397,6 +397,17 @@ message ClientIncidentReport {
}
optional Channel chrome_update_channel = 5;
optional int64 uptime_msec = 6;
+ message Dll {
+ enum Feature {
+ UNKNOWN = 0;
+ LSP = 1;
+ }
+ optional string path = 1;
+ optional uint64 base_address = 2;
+ optional uint32 length = 3;
+ repeated Feature feature = 4;
+ }
+ repeated Dll dll = 9;
}
optional Process process = 3;
}

Powered by Google App Engine
This is Rietveld 408576698