Stack at top functionality for Aura-based windows

Stack at top functionality for Aura-based windows

Implementation of previously empty DesktopNativeWidgetAura::StackAtTop()
method.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238978

[Ben Goodger (Google), 2013-10-21 17:42:59]

Is this needed by something? Can you cite a bug?

[Tomasz Moniuszko, 2013-10-24 08:23:23]

On 2013/10/21 17:42:59, Ben Goodger (Google) wrote:
> Is this needed by something? Can you cite a bug?

Yes, it's needed by functionality of dragging tab between browser windows in
Opera but I think you can consider this as a bug also in Chromium. In non-Aura
build an inactive browser window is brought to front if you drag a tab over it
and wait some time. In Aura build (Chrome Canary) this functionality doesn't
work: you need to move a tab directly over the tab strip to activate the window.
It's not very convenient especially if the tab strip of the target window is
hidden by the active window.

[Ben Goodger (Google), 2013-10-24 16:41:27]

lgtm

[commit-bot: I haz the power, 2013-10-25 07:28:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tmoniuszko@opera.com/32393002/1

[commit-bot: I haz the power, 2013-10-25 08:20:58]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Tomasz Moniuszko, 2013-10-25 09:22:34]

On 2013/10/24 16:41:27, Ben Goodger (Google) wrote:
> lgtm

Code base changed meantime. Could you please have another look at the updated
patch?

[commit-bot: I haz the power, 2013-10-30 11:00:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tmoniuszko@opera.com/32393002/310001

[commit-bot: I haz the power, 2013-10-30 11:33:04]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Tomasz Moniuszko, 2013-10-30 15:49:26]

Hi Elliot,
I added fix for X11 compilation error. Could you please have a look at these
changes?
Thanks,
Tomasz

[Elliot Glaysher, 2013-10-30 18:13:30]

https://codereview.chromium.org/32393002/diff/550001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc (right):

https://codereview.chromium.org/32393002/diff/550001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc:293:
NOTIMPLEMENTED();
:(

Can you implement this?

[Tomasz Moniuszko, 2013-10-31 08:33:43]

https://codereview.chromium.org/32393002/diff/550001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc (right):

https://codereview.chromium.org/32393002/diff/550001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc:293:
NOTIMPLEMENTED();
On 2013/10/30 18:13:30, Elliot Glaysher wrote:
> :(
> 
> Can you implement this?

Done. Could you please have a look?

[Elliot Glaysher, 2013-10-31 17:39:16]

ty

lgtm

[commit-bot: I haz the power, 2013-11-04 08:26:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tmoniuszko@opera.com/32393002/650001

[commit-bot: I haz the power, 2013-11-04 10:25:54]

Retried try job too often on win_rel for step(s) content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-06 09:41:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tmoniuszko@opera.com/32393002/650001

[commit-bot: I haz the power, 2013-11-06 12:01:53]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-12-05 13:12:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tmoniuszko@opera.com/32393002/1030001

[commit-bot: I haz the power, 2013-12-05 15:57:13]

Change committed as 238978