Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: Source/modules/geolocation/GeolocationController.cpp

Issue 323873007: Oilpan: Make LocalFrame PersistentHeapSupplementable and use transition types for its supplements. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/geolocation/GeolocationController.cpp
diff --git a/Source/modules/geolocation/GeolocationController.cpp b/Source/modules/geolocation/GeolocationController.cpp
index 70d19b3f476b4784de77fd543f84ead898d5d33b..335cd6a163e8cc02f579c22f9057dba81d52602f 100644
--- a/Source/modules/geolocation/GeolocationController.cpp
+++ b/Source/modules/geolocation/GeolocationController.cpp
@@ -96,9 +96,9 @@ void GeolocationController::willBeDestroyed()
m_client->geolocationDestroyed();
}
-PassOwnPtr<GeolocationController> GeolocationController::create(LocalFrame& frame, GeolocationClient* client)
+PassOwnPtrWillBeRawPtr<GeolocationController> GeolocationController::create(LocalFrame& frame, GeolocationClient* client)
{
- return adoptPtr(new GeolocationController(frame, client));
+ return adoptPtrWillBeNoop(new GeolocationController(frame, client));
}
void GeolocationController::addObserver(Geolocation* observer, bool enableHighAccuracy)
@@ -205,9 +205,17 @@ const char* GeolocationController::supplementName()
return "GeolocationController";
}
+void GeolocationController::trace(Visitor* visitor)
+{
+ visitor->trace(m_lastPosition);
+ visitor->trace(m_observers);
+ visitor->trace(m_highAccuracyObservers);
+ WillBeHeapSupplement<LocalFrame>::trace(visitor);
+}
+
void provideGeolocationTo(LocalFrame& frame, GeolocationClient* client)
{
- Supplement<LocalFrame>::provideTo(frame, GeolocationController::supplementName(), GeolocationController::create(frame, client));
+ WillBeHeapSupplement<LocalFrame>::provideTo(frame, GeolocationController::supplementName(), GeolocationController::create(frame, client));
}
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698