Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 323873007: Oilpan: Make LocalFrame PersistentHeapSupplementable and use transition types for its supplements. (Closed)

Created:
6 years, 6 months ago by zerny-chromium
Modified:
6 years, 6 months ago
CC:
blink-reviews, Mads Ager (chromium), timvolodine, mvanouwerkerk+watch_chromium.org, tommyw+watchlist_chromium.org, kouhei+heap_chromium.org, oilpan-reviews, mlamouri (slow - plz ping)
Visibility:
Public.

Description

Oilpan: Make LocalFrame PersistentHeapSupplementable and use transition types for its supplements. R=haraken@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175900

Patch Set 1 #

Total comments: 6

Patch Set 2 : actually make it persistent #

Patch Set 3 : non-oilpan build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -33 lines) Patch
M Source/core/frame/LocalFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/GeolocationController.h View 3 chunks +8 lines, -5 lines 0 comments Download
M Source/modules/geolocation/GeolocationController.cpp View 2 chunks +11 lines, -3 lines 0 comments Download
M Source/modules/mediastream/UserMediaController.h View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M Source/modules/mediastream/UserMediaController.cpp View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M Source/modules/notifications/NotificationController.h View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/modules/notifications/NotificationController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIController.h View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/modules/webmidi/MIDIController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/Supplementable.h View 1 3 chunks +21 lines, -2 lines 0 comments Download
M Source/platform/heap/Handle.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
zerny-chromium
6 years, 6 months ago (2014-06-10 11:34:11 UTC) #1
Mads Ager (chromium)
https://codereview.chromium.org/323873007/diff/1/Source/platform/Supplementable.h File Source/platform/Supplementable.h (right): https://codereview.chromium.org/323873007/diff/1/Source/platform/Supplementable.h#newcode231 Source/platform/Supplementable.h:231: TraceDelegate m_root; Don't you need a Persistent here somewhere? ...
6 years, 6 months ago (2014-06-10 11:50:26 UTC) #2
zerny-chromium
https://codereview.chromium.org/323873007/diff/1/Source/platform/Supplementable.h File Source/platform/Supplementable.h (right): https://codereview.chromium.org/323873007/diff/1/Source/platform/Supplementable.h#newcode231 Source/platform/Supplementable.h:231: TraceDelegate m_root; On 2014/06/10 11:50:26, Mads Ager (chromium) wrote: ...
6 years, 6 months ago (2014-06-10 11:52:04 UTC) #3
haraken
https://codereview.chromium.org/323873007/diff/1/Source/modules/geolocation/GeolocationController.h File Source/modules/geolocation/GeolocationController.h (right): https://codereview.chromium.org/323873007/diff/1/Source/modules/geolocation/GeolocationController.h#newcode85 Source/modules/geolocation/GeolocationController.h:85: PersistentWillBeMember<GeolocationPosition> m_lastPosition; This should be RefPtrWillBeMember. https://codereview.chromium.org/323873007/diff/1/Source/modules/geolocation/GeolocationController.h#newcode86 Source/modules/geolocation/GeolocationController.h:86: typedef ...
6 years, 6 months ago (2014-06-10 12:04:34 UTC) #4
zerny-chromium
Made TraceDelegate a PersistentBase so the node is inlined in the PersistentHeapSupplementable. The reason I ...
6 years, 6 months ago (2014-06-10 12:05:48 UTC) #5
Mads Ager (chromium)
LGTM
6 years, 6 months ago (2014-06-10 12:12:35 UTC) #6
zerny-chromium
https://codereview.chromium.org/323873007/diff/1/Source/modules/geolocation/GeolocationController.h File Source/modules/geolocation/GeolocationController.h (right): https://codereview.chromium.org/323873007/diff/1/Source/modules/geolocation/GeolocationController.h#newcode85 Source/modules/geolocation/GeolocationController.h:85: PersistentWillBeMember<GeolocationPosition> m_lastPosition; On 2014/06/10 12:04:34, haraken wrote: > > ...
6 years, 6 months ago (2014-06-10 12:12:51 UTC) #7
zerny-chromium
+tkent for platform/
6 years, 6 months ago (2014-06-10 12:13:33 UTC) #8
haraken
LGTM. > https://codereview.chromium.org/323873007/diff/1/Source/modules/geolocation/GeolocationController.h#newcode85 > Source/modules/geolocation/GeolocationController.h:85: > PersistentWillBeMember<GeolocationPosition> m_lastPosition; > On 2014/06/10 12:04:34, haraken wrote: > ...
6 years, 6 months ago (2014-06-10 12:27:07 UTC) #9
tkent
lgtm
6 years, 6 months ago (2014-06-10 13:01:51 UTC) #10
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 6 months ago (2014-06-10 15:33:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/323873007/40001
6 years, 6 months ago (2014-06-10 15:33:58 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 16:41:47 UTC) #13
Message was sent while issue was closed. 
Change committed as 175900

Powered by Google App Engine
This is Rietveld 408576698