Add unpatched OpenBSD trees to tools/android/heap_profiler/

Add unpatched OpenBSD trees to tools/android/heap_profiler/

OpenBSD trees are the most convenient C implementation
of RB-Trees (just one header file).
This is needed for libheap_profiler, a library for profiling
memory allocations on Android (and probably later on Linux)
which must be a dependency-free.
Note: the target library is not mean to be shipped as part
of Chrome. It is a separate tool which can be build
and deployed separately for debugging/profiling purposes.

BUG=382489
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281021

[Primiano Tucci (use gerrit), 2014-06-09 18:25:23]

Hi open-source-third-party-reviews,
could you please take a look to this change.
It is checking in one .h file from OpenBSD source code,

If it can help with the legal viewpoint, the original author of the BSD code is
Niels Provos (as reported in the file header), who is now an illustrious
Googler. )

[chromium-reviews, 2014-06-19 12:29:21]

PING.

https://codereview.chromium.org/323873004/  has been sitting here for 10 
days and is just one BSD-licensed header file written by somebody who is 
now part of Google.

Are there any concerns?

Thanks,
Primiano

On Monday, June 9, 2014 7:25:23 PM UTC+1, primiano@chromium.org wrote:
>
> Reviewers: open-source-third-party-reviews_google.com, bulach, 
>
> Message: 
> Hi open-source-third-party-reviews, 
> could you please take a look to this change. 
> It is checking in one .h file from OpenBSD source code, 
>
> If it can help with the legal viewpoint, the original author of the BSD   
> code is 
> Niels Provos (as reported in the file header), who is now an illustrious 
> Googler. ) 
>
>
> Description: 
> Add unpatched OpenBSD trees to tools/android/heap_profiler/ 
>
> OpenBSD trees are the most convenient C implementation 
> of RB-Trees (just one header file). 
> This is needed for libheap_profiler, a library for profiling 
> memory allocations on Android (and probably later on Linux) 
> which must be a dependency-free. 
> Note: the target library is not mean to be shipped as part 
> of Chrome. It is a separate tool which can be build 
> and deployed separately for debugging/profiling purposes. 
>
> BUG=382489 
>
> Please review this at https://codereview.chromium.org/323873004/ 
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master 
>
> Affected files (+763, -0 lines): 
>    A tools/android/heap_profiler/third_party/bsd-trees/README.chromium 
>    A tools/android/heap_profiler/third_party/bsd-trees/tree.h 
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Daniel Berlin, 2014-06-19 13:20:47]

Is there some very good reason this shouldn't be third_party/bsd-trees and used
from there?

We'd much rather not have a large number of third-party trees in chromium to
manage (we already have a small number).

[Primiano Tucci (use gerrit), 2014-06-19 14:01:51]

On 2014/06/19 13:20:47, Daniel Berlin wrote:
> Is there some very good reason this shouldn't be third_party/bsd-trees and
used
> from there?
> 
> We'd much rather not have a large number of third-party trees in chromium to
> manage (we already have a small number).

Not really. I thought that since it is just a header and not a complete library
we'd prefer not polluting third_party.
It seems this is not the case, so moving it.
Thanks

P.S. Sorry for the nag, I was fearing it just got lost in somebody's inbox.

[chromium-reviews, 2014-06-19 15:43:44]

LGTM
No worries, please feel free to nag the heck out of me if you don't
get a response in about 12 hours to any review.


On Thu, Jun 19, 2014 at 7:01 AM,  <primiano@chromium.org> wrote:
> On 2014/06/19 13:20:47, Daniel Berlin wrote:
>>
>> Is there some very good reason this shouldn't be third_party/bsd-trees and
>
> used
>>
>> from there?
>
>
>> We'd much rather not have a large number of third-party trees in chromium
>> to
>> manage (we already have a small number).
>
>
> Not really. I thought that since it is just a header and not a complete
> library
> we'd prefer not polluting third_party.
> It seems this is not the case, so moving it.
> Thanks
>
> P.S. Sorry for the nag, I was fearing it just got lost in somebody's inbox.
>
> https://codereview.chromium.org/323873004/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Primiano Tucci (use gerrit), 2014-06-20 08:36:53]

Just to confirm, does this count as a legal approval?
In other words, can I go ahead and merge this or do I have to wait also for LG
from somebody else?

Thanks

On 2014/06/19 15:43:44, chromium-reviews wrote:
> LGTM
> No worries, please feel free to nag the heck out of me if you don't
> get a response in about 12 hours to any review.
> 
> 
> On Thu, Jun 19, 2014 at 7:01 AM,  <mailto:primiano@chromium.org> wrote:
> > On 2014/06/19 13:20:47, Daniel Berlin wrote:
> >>
> >> Is there some very good reason this shouldn't be third_party/bsd-trees and
> >
> > used
> >>
> >> from there?
> >
> >
> >> We'd much rather not have a large number of third-party trees in chromium
> >> to
> >> manage (we already have a small number).
> >
> >
> > Not really. I thought that since it is just a header and not a complete
> > library
> > we'd prefer not polluting third_party.
> > It seems this is not the case, so moving it.
> > Thanks
> >
> > P.S. Sorry for the nag, I was fearing it just got lost in somebody's inbox.
> >
> > https://codereview.chromium.org/323873004/
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Primiano Tucci (use gerrit), 2014-06-26 13:42:38]

FTR, was some weird mail rewrite happened here.
The green light came from dannyb@ (but rietveld shows it as chromium-reviews@)

Attaching the headers of the original mail for historical records:
                                                                                
                                                                                
                                                                                
       
Delivered-To: primiano@google.com
Received: by 10.52.96.137 with SMTP id ds9csp4037vdb;
        Thu, 19 Jun 2014 08:43:44 -0700 (PDT)
X-Received: by 10.43.1.65 with SMTP id np1mr6743701icb.48.1403192624555;
        Thu, 19 Jun 2014 08:43:44 -0700 (PDT)
Return-Path: <dannyb@google.com>
Received: from mail-ie0-f172.google.com (mail-ie0-f172.google.com
[209.85.223.172])
        by mx.google.com with ESMTPS id no3si4860157igb.29.2014.06.19.08.43.44
        for <primiano@google.com>
        (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Thu, 19 Jun 2014 08:43:44 -0700 (PDT)
Received-SPF: pass (google.com: domain of dannyb@google.com designates
209.85.223.172 as permitted sender) client-ip=209.85.223.172;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of dannyb@google.com designates
209.85.223.172 as permitted sender) smtp.mail=dannyb@google.com;
       dkim=pass header.i=@google.com;
       dmarc=pass (p=REJECT dis=NONE) header.from=google.com
Received: by mail-ie0-f172.google.com with SMTP id lx4so2139957iec.31
        for <primiano@google.com>; Thu, 19 Jun 2014 08:43:44 -0700 (PDT)
X-Received: by 10.43.117.133 with SMTP id fm5mr6806384icc.3.1403192624234;
        Thu, 19 Jun 2014 08:43:44 -0700 (PDT)
X-Gm-Message-State:
ALoCoQmbzq2RXbQUVN2Nl+Yxdqib9JNPMfZ8iGc4lKqJcWU1MEXN8PFjt362EhlI9YKShzKMKDvMpEIbG0MPQo/ORYb/eQZ9Ow==
X-Received: by 10.43.117.133 with SMTP id fm5mr6806349icc.3.1403192623934;
        Thu, 19 Jun 2014 08:43:43 -0700 (PDT)
Return-Path: <dannyb@google.com>
Received: from mail-ie0-x231.google.com (mail-ie0-x231.google.com
[2607:f8b0:4001:c03::231])
        by mx.google.com with ESMTPS id rh8si4920765igc.48.2014.06.19.08.43.43
        for <primiano@chromium.org>
        (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Thu, 19 Jun 2014 08:43:43 -0700 (PDT)
Received-SPF: pass (google.com: domain of dannyb@google.com designates
2607:f8b0:4001:c03::231 as permitted sender) client-ip=2607:f8b0:4001:c03::231;
Received: by mail-ie0-f177.google.com with SMTP id tp5so2044495ieb.8
        for <primiano@chromium.org>; Thu, 19 Jun 2014 08:43:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=bAngo0t8Xxs58ezZk1/Y3b+z652TdnyyxaJdE6+NQTY=;
        b=CUnv28Hd3HoqV1fUEAckKiCMCL7Vs5gM0Lt1YLqrS/2bOy3TzxFIaIWl7UPan8Iv8e
         SXfS0AhIujCWQrN1ve3C61yNyR884fpXLb1wxZkB341mVNghjNcLyOBGPO+n6Q1RuvLP
         PAp1IGgReV9LSp6HOr7L5fFbkAiIycRrAc3Lq4lLa+bcDzNtmHdWah3tDBQ3lrU6GgvP
         AGOQxql2xuNyt1+1+4HfBNgoD0t0NT7cqZ+D7I2SfP4pWKzJKup6Zzpz+ksFOBRIuEpP
         egyPdWhte1Xi0X+tFKyXKelYUw+8LqzoGKs9x4O+HwQZeyFBi09MlGTVXnxHoaFLYLlD
         yWbA==
MIME-Version: 1.0
X-Received: by 10.42.12.6 with SMTP id w6mr6610408icw.69.1403192623716; Thu,
 19 Jun 2014 08:43:43 -0700 (PDT)
Received: by 10.64.226.77 with HTTP; Thu, 19 Jun 2014 08:43:43 -0700 (PDT)
In-Reply-To: <001a11c1f5d89636b304fc30d17e@google.com>
References: <001a11c1f5d89636b304fc30d17e@google.com>
Date: Thu, 19 Jun 2014 08:43:43 -0700
Message-ID: <CABTcG6KeUdKO3D1TWqCAeJcin7EdhTStOLoubMF9eG+p7+121w@mail.gmail.com>
Subject: Re: Add unpatched OpenBSD trees to tools/android/heap_profiler/
 (issue 323873004 by primiano@chromium.org)
From: Daniel Berlin <dannyb@google.com>
To: primiano@chromium.org, 
	open-source-third-party-reviews <open-source-third-party-reviews@google.com>,
bulach@chromium.org, 
	Daniel Berlin <dannyb@google.com>, 
	"chromium-reviews@chromium.org" <chromium-reviews@chromium.org>,
klundberg+watch@chromium.org, 
	bulach+watch@chromium.org, yfriedman+watch@chromium.org, 
	ilevy-cc@chromium.org, dmikurube@chromium.org
Content-Type: text/plain; charset=UTF-8

[Primiano Tucci (use gerrit), 2014-06-26 13:43:18]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2014-06-26 13:44:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/primiano@chromium.org/323873004/20001

[commit-bot: I haz the power, 2014-06-26 13:44:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-26 13:44:30]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Primiano Tucci (use gerrit), 2014-06-26 14:14:32]

+brettw for the chromium approval.

[chromium-reviews, 2014-06-26 15:33:34]

Just FYI: My approval always counts as legal approval for open source.


On Fri, Jun 20, 2014 at 1:36 AM,  <primiano@chromium.org> wrote:
> Just to confirm, does this count as a legal approval?
> In other words, can I go ahead and merge this or do I have to wait also for
> LG
> from somebody else?
>
> Thanks
>
>
> On 2014/06/19 15:43:44, chromium-reviews wrote:
>>
>> LGTM
>> No worries, please feel free to nag the heck out of me if you don't
>> get a response in about 12 hours to any review.
>
>
>
>> On Thu, Jun 19, 2014 at 7:01 AM,  <mailto:primiano@chromium.org> wrote:
>> > On 2014/06/19 13:20:47, Daniel Berlin wrote:
>> >>
>> >> Is there some very good reason this shouldn't be third_party/bsd-trees
>> >> and
>> >
>> > used
>> >>
>> >> from there?
>> >
>> >
>> >> We'd much rather not have a large number of third-party trees in
>> >> chromium
>> >> to
>> >> manage (we already have a small number).
>> >
>> >
>> > Not really. I thought that since it is just a header and not a complete
>> > library
>> > we'd prefer not polluting third_party.
>> > It seems this is not the case, so moving it.
>> > Thanks
>> >
>> > P.S. Sorry for the nag, I was fearing it just got lost in somebody's
>> > inbox.
>> >
>> > https://codereview.chromium.org/323873004/
>
>
>> To unsubscribe from this group and stop receiving emails from it, send an
>
> email
>>
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>
>
>
>
> https://codereview.chromium.org/323873004/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brettw, 2014-06-30 17:41:58]

lgtm

[Primiano Tucci (use gerrit), 2014-07-02 07:15:14]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2014-07-02 07:15:17]

The CQ bit was unchecked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2014-07-02 07:15:33]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2014-07-02 07:16:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/primiano@chromium.org/323873004/20001

[commit-bot: I haz the power, 2014-07-02 13:07:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Primiano Tucci (use gerrit), 2014-07-02 13:54:14]

The CQ bit was unchecked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2014-07-02 13:54:19]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2014-07-02 13:55:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/primiano@chromium.org/323873004/20001

[commit-bot: I haz the power, 2014-07-02 13:57:31]

Change committed as 281021