Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1490)

Unified Diff: Source/devtools/front_end/timeline/TracingModel.js

Issue 323873002: Timeline: do not remove trace object snapshots from event list of their threads (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TracingModel.js
diff --git a/Source/devtools/front_end/timeline/TracingModel.js b/Source/devtools/front_end/timeline/TracingModel.js
index 77cf1e72bfc62248836fe39fa447fc2e70c7ff5f..875c75b5bced127364d27ab3007628e2f3bfd643 100644
--- a/Source/devtools/front_end/timeline/TracingModel.js
+++ b/Source/devtools/front_end/timeline/TracingModel.js
@@ -185,11 +185,6 @@ WebInspector.TracingModel.prototype = {
this._processById[payload.pid] = process;
}
var thread = process.threadById(payload.tid);
- if (payload.ph === WebInspector.TracingModel.Phase.SnapshotObject) {
- var event = thread.addEvent(payload);
- process.addObject(event);
- return;
- }
if (payload.ph !== WebInspector.TracingModel.Phase.Metadata) {
var timestamp = payload.ts / 1000;
// We do allow records for unrelated threads to arrive out-of-order,
@@ -199,6 +194,8 @@ WebInspector.TracingModel.prototype = {
if (!this._maximumRecordTime || timestamp > this._maximumRecordTime)
this._maximumRecordTime = timestamp;
var event = thread.addEvent(payload);
+ if (payload.ph === WebInspector.TracingModel.Phase.SnapshotObject)
+ process.addObject(event);
if (event && event.name === WebInspector.TracingModel.DevToolsMetadataEvent.TracingStartedInPage &&
event.category === WebInspector.TracingModel.DevToolsMetadataEventCategory &&
event.args["sessionId"] === this._sessionId)

Powered by Google App Engine
This is Rietveld 408576698