[PowerProfiler] Make monsoon profiler work on other platforms - windows & mac, apart from linu…

[PowerProfiler] Make monsoon profiler work on other platforms - windows & mac, apart from linux.

We can utilize serial.tools.list_ports module to get the list of serial devices connected in a
platform independent way. If this works, the power monitor with monsoon should work seamlessly
across all the platforms namely: Linux (already supported), Windows, Mac.

BUG=386789
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279679

[vivekg, 2014-06-09 12:22:52]

@tonyg, please take a look at the patch and let me know your comments. This is
still a work in progress patch.

[vivekg, 2014-06-09 12:28:53]

This patche depends on the other CL in review:
https://codereview.chromium.org/321773002/

[tonyg, 2014-06-09 16:51:57]

Two nits to address before landing. But lgtm after that.

https://codereview.chromium.org/323853002/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/platform/profiler/monsoon.py (right):

https://codereview.chromium.org/323853002/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/profiler/monsoon.py:60: for dev in
devices:
This loop'd be a lot more readable as

for port, desc, hwid in serial.tools.list_ports.comports():

https://codereview.chromium.org/323853002/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/profiler/monsoon.py:63: tmpname =
'/tmp/monsoon.%s.%s' % (os.uname()[0], os.path.basename(dev[0]))
nit: please hold line length to 80 cols.

http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Line_length

[vivekg, 2014-06-24 14:19:19]

Thank you.

On 2014/06/09 16:51:57, tonyg wrote:
> Two nits to address before landing. But lgtm after that.
> 
>
https://codereview.chromium.org/323853002/diff/1/tools/telemetry/telemetry/co...
> File tools/telemetry/telemetry/core/platform/profiler/monsoon.py (right):
> 
>
https://codereview.chromium.org/323853002/diff/1/tools/telemetry/telemetry/co...
> tools/telemetry/telemetry/core/platform/profiler/monsoon.py:60: for dev in
> devices:
> This loop'd be a lot more readable as
> 
> for port, desc, hwid in serial.tools.list_ports.comports():

Done.

> 
>
https://codereview.chromium.org/323853002/diff/1/tools/telemetry/telemetry/co...
> tools/telemetry/telemetry/core/platform/profiler/monsoon.py:63: tmpname =
> '/tmp/monsoon.%s.%s' % (os.uname()[0], os.path.basename(dev[0]))
> nit: please hold line length to 80 cols.
> 
> http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Line_length

Done.

[vivekg, 2014-06-25 06:12:15]

On 2014/06/24 at 14:19:19, vivekg_ wrote:
> Thank you.
> 
> On 2014/06/09 16:51:57, tonyg wrote:
> > Two nits to address before landing. But lgtm after that.
> > 
> >
https://codereview.chromium.org/323853002/diff/1/tools/telemetry/telemetry/co...
> > File tools/telemetry/telemetry/core/platform/profiler/monsoon.py (right):
> > 
> >
https://codereview.chromium.org/323853002/diff/1/tools/telemetry/telemetry/co...
> > tools/telemetry/telemetry/core/platform/profiler/monsoon.py:60: for dev in
> > devices:
> > This loop'd be a lot more readable as
> > 
> > for port, desc, hwid in serial.tools.list_ports.comports():
> 
> Done.
> 
> > 
> >
https://codereview.chromium.org/323853002/diff/1/tools/telemetry/telemetry/co...
> > tools/telemetry/telemetry/core/platform/profiler/monsoon.py:63: tmpname =
> > '/tmp/monsoon.%s.%s' % (os.uname()[0], os.path.basename(dev[0]))
> > nit: please hold line length to 80 cols.
> > 
> > http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Line_length
> 
> Done.

@tonyg: Can you please rubber-stamp it again before we land it? This could also
fix the issue reported here [1]

[1] http://code.google.com/p/chromium/issues/detail?id=386789

[tonyg, 2014-06-25 06:15:59]

lgtm

For future reference, you can just take an lgtm if the comments with it are
addressed.

[commit-bot: I haz the power, 2014-06-25 06:17:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/323853002/20001

[vivekg, 2014-06-25 06:18:34]

On 2014/06/25 at 06:15:59, tonyg wrote:
> lgtm
> 
> For future reference, you can just take an lgtm if the comments with it are
addressed.

Thank you! And sure, would take a note of it. :)

[commit-bot: I haz the power, 2014-06-25 11:53:55]

Change committed as 279679