tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py - Issue 323833003: Create ActionRunner wrapper API over TapAction and ClickElementAction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

Issue 323833003: Create ActionRunner wrapper API over TapAction and ClickElementAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Undo deletion of wait_until (to be done in separate patch). Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/page/actions/all_page_actions.py ('K') | « tools/telemetry/telemetry/page/actions/tap.py ('k') | tools/telemetry/unittest_data/page_with_clickables.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

index 3ffc69abb7612c50e604621efc1e70237807cd31..b81d3e3980c2333486a49a7be0d59e1fd42827bd 100644

--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

@@ -109,8 +109,7 @@ class TestTimelinebasedMeasurementPage(page_module.Page):

def RunSmoothness(self, action_runner):

action_runner.Wait(2)

- action_runner.RunAction(TapAction(

- {'selector': '#drawer', 'automatically_record_interaction': False}))

+ action_runner.TapElement('#drawer')

action_runner.Wait(1)