tools/perf/page_sets/plus_alt_posts_photos.py - Issue 323833003: Create ActionRunner wrapper API over TapAction and ClickElementAction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/plus_alt_posts_photos.py

Issue 323833003: Create ActionRunner wrapper API over TapAction and ClickElementAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Undo deletion of wait_until (to be done in separate patch). Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/perf/page_sets/key_silk_cases.py ('K') | « tools/perf/page_sets/key_silk_cases.py ('k') | tools/perf/page_sets/polymer.py » ('j') | tools/telemetry/telemetry/page/actions/all_page_actions.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/page_sets/plus_alt_posts_photos.py

diff --git a/tools/perf/page_sets/plus_alt_posts_photos.py b/tools/perf/page_sets/plus_alt_posts_photos.py

index 5aa53babd4f1f1a1a1b2fe76b6e1c8895ab3b95e..aa4483852a0d4f1f7d044dde98522c28aadf06d8 100644

--- a/tools/perf/page_sets/plus_alt_posts_photos.py

+++ b/tools/perf/page_sets/plus_alt_posts_photos.py

@@ -28,17 +28,11 @@ class PlusAltPostsPhotosPage(page_module.Page):

'span[guidedhelpid="posts_tab_profile"][class*="s6U8x"]')

def RunEndure(self, action_runner):

- action_runner.RunAction(ClickElementAction(

- {

- 'selector': 'span[guidedhelpid="posts_tab_profile"]'

- }))

+ action_runner.ClickElement('span[guidedhelpid="posts_tab_profile"]')

action_runner.WaitForElement(

'span[guidedhelpid="posts_tab_profile"][class*="s6U8x"]')

action_runner.Wait(5)

- action_runner.RunAction(ClickElementAction(

- {

- 'selector': 'span[guidedhelpid="photos_tab_profile"]'

- }))

+ action_runner.ClickElement('span[guidedhelpid="photos_tab_profile"]')

action_runner.WaitForElement(

'span[guidedhelpid="photos_tab_profile"][class*="s6U8x"]')

action_runner.Wait(5)