tools/perf/page_sets/key_mobile_sites.py - Issue 323833003: Create ActionRunner wrapper API over TapAction and ClickElementAction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/key_mobile_sites.py

Issue 323833003: Create ActionRunner wrapper API over TapAction and ClickElementAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Undo deletion of wait_until (to be done in separate patch). Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/key_mobile_sites.py

diff --git a/tools/perf/page_sets/key_mobile_sites.py b/tools/perf/page_sets/key_mobile_sites.py

index b2c9e91d9a66186c95ab8d19ce8cd24adab242a4..b67c5c3ca69be94cbc2b001626b3fc9074f99640 100644

--- a/tools/perf/page_sets/key_mobile_sites.py

+++ b/tools/perf/page_sets/key_mobile_sites.py

@@ -245,10 +245,7 @@ class Page16(KeyMobileSitesPage):

def RunNavigateSteps(self, action_runner):

action_runner.NavigateToPage(self)

action_runner.WaitForElement(text='Other Answers (1 - 20 of 149)')

- action_runner.RunAction(ClickElementAction(

- {

- 'text': 'Other Answers (1 - 20 of 149)'

- }))

+ action_runner.ClickElement(text='Other Answers (1 - 20 of 149)')

class Page17(KeyMobileSitesPage):

« no previous file with comments | « tools/perf/page_sets/indexeddb_offline.py ('k') | tools/perf/page_sets/key_silk_cases.py » ('j') | tools/perf/page_sets/key_silk_cases.py » ('J')