Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 323803003: Sort Java AIDL input filenames for makefile stability. (Closed)

Created:
6 years, 6 months ago by Torne
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Sort Java AIDL input filenames for makefile stability. Sort the list of input java files for the aidl build step so that the contents of generated makefiles in WebView have a stable ordering. BUG= Committed: https://crrev.com/8eff03f99038a90198095d0bab3363a249357cb5 Cr-Commit-Position: refs/heads/master@{#292686}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/java_aidl.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
Torne
Hi Chris, David, r173333 introduced this list of files which is in no particular order ...
6 years, 6 months ago (2014-06-09 14:07:48 UTC) #1
cjhopman
On 2014/06/09 14:07:48, Torne wrote: > Hi Chris, David, > > r173333 introduced this list ...
6 years, 6 months ago (2014-06-09 14:51:51 UTC) #2
Torne
On 2014/06/09 14:51:51, cjhopman wrote: > On 2014/06/09 14:07:48, Torne wrote: > > Hi Chris, ...
6 years, 6 months ago (2014-06-09 14:59:15 UTC) #3
David Trainor- moved to gerrit
On 2014/06/09 14:59:15, Torne wrote: > On 2014/06/09 14:51:51, cjhopman wrote: > > On 2014/06/09 ...
6 years, 6 months ago (2014-06-09 17:59:51 UTC) #4
Torne
I had a look at doing it in the generator, but lots of other parts ...
6 years, 3 months ago (2014-08-29 17:17:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/323803003/1
6 years, 3 months ago (2014-08-29 17:18:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/323803003/20001
6 years, 3 months ago (2014-08-29 17:29:56 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-29 18:43:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 813d3d9165125da4c738c2ce17762a204057344e
6 years, 3 months ago (2014-08-29 22:16:41 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:10:39 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8eff03f99038a90198095d0bab3363a249357cb5
Cr-Commit-Position: refs/heads/master@{#292686}

Powered by Google App Engine
This is Rietveld 408576698