Issue 3238015: Fix two bugs for setting the pdf plugin on by default:...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3238015: Fix two bugs for setting the pdf plugin on by default:... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by jam

Modified:
4 years ago

Reviewers:
viettrungluu

CC:
chromium-reviews, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix two bugs for setting the pdf plugin on by default: -fix regression in enabling the plugin after the PluginGroup change -rename the pref name, and add a dcheck to ensure this always is done, every time the plugin flips from enabled->disabled by default Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58072

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	chrome/browser/plugin_updater.cc	View		4 chunks	+22 lines, -0 lines	0 comments	Download

Trybot results: win mac linux

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

no not yet, only if we disable the internal pdf plugin by default On Tue, ...

4 years, 9 months ago (2010-08-31 20:50:25 UTC) #3

Okay, LGTM then.

Expand Messages | Collapse Messages