Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 323783002: Files.app: Explicitly add o+r permission to mounted zip archives under Downloads. (Closed)

Created:
6 years, 6 months ago by kinaba
Modified:
6 years, 6 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Files.app: Explicitly add o+r permission to mounted zip archives under Downloads. After the change r274593, downloaded files started to have permission 0640 rather than 0644. This CL explicitly adds read-permission before mounting, provided the archive file is located under the local Downloads folder. The modification is not applied to zip files on external storage because (1) the silent change of permission may not be what the user want, (2) it should be rare that download destination is set to removable devices, and (3) according to UMA stat 99% of mounted filesystems are those we mount ignoring permissions anyhow (FAT, NTFS, ISO9660, ...). BUG=381144 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -2 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc View 4 chunks +51 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
6 years, 6 months ago (2014-06-09 03:22:38 UTC) #1
hashimoto
lgtm
6 years, 6 months ago (2014-06-09 04:44:14 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 6 months ago (2014-06-09 05:25:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/323783002/1
6 years, 6 months ago (2014-06-09 05:26:11 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-09 06:51:20 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 06:59:21 UTC) #6
Message was sent while issue was closed.
Change committed as 275777

Powered by Google App Engine
This is Rietveld 408576698