Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 323763003: Move BookmarkMatch into bookmarks namespace. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, James Su, blundell, sdefresne, nshaik
Visibility:
Public.

Description

Move BookmarkMatch into bookmarks namespace. BUG=370433 TEST=None R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276565

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M chrome/browser/autocomplete/bookmark_provider.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/bookmark_provider.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/bookmark_provider_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/importer/profile_writer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_index.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_match.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_match.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.h View 1 3 chunks +4 lines, -6 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tfarina
6 years, 6 months ago (2014-06-08 22:51:03 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-09 15:57:18 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-11 23:37:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/323763003/1
6 years, 6 months ago (2014-06-11 23:38:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 23:52:31 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 23:57:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/12944) linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/22638) linux_chromium_chromeos_rel ...
6 years, 6 months ago (2014-06-11 23:57:01 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-12 01:07:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/323763003/20001
6 years, 6 months ago (2014-06-12 01:08:48 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 07:37:12 UTC) #10
Message was sent while issue was closed. 
Change committed as 276565

Powered by Google App Engine
This is Rietveld 408576698