Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/hydrogen.cc

Issue 32373002: Revert "Add a soft-deopt in keyed element access when current IC is pre-monomorphic and no type fee… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.cc ('k') | src/type-info.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5774 matching lines...) Expand 10 before | Expand all | Expand 10 after
5785 BuildCheckHeapObject(obj); 5785 BuildCheckHeapObject(obj);
5786 instr = BuildMonomorphicElementAccess( 5786 instr = BuildMonomorphicElementAccess(
5787 obj, key, val, NULL, map, is_store, expr->GetStoreMode()); 5787 obj, key, val, NULL, map, is_store, expr->GetStoreMode());
5788 } 5788 }
5789 } else if (types != NULL && !types->is_empty()) { 5789 } else if (types != NULL && !types->is_empty()) {
5790 return HandlePolymorphicElementAccess( 5790 return HandlePolymorphicElementAccess(
5791 obj, key, val, types, position, is_store, 5791 obj, key, val, types, position, is_store,
5792 expr->GetStoreMode(), has_side_effects); 5792 expr->GetStoreMode(), has_side_effects);
5793 } else { 5793 } else {
5794 if (is_store) { 5794 if (is_store) {
5795 if (expr->IsAssignment() && 5795 if (expr->IsAssignment() && expr->AsAssignment()->IsUninitialized()) {
5796 expr->AsAssignment()->HasNoTypeInformation()) {
5797 Add<HDeoptimize>("Insufficient type feedback for keyed store", 5796 Add<HDeoptimize>("Insufficient type feedback for keyed store",
5798 Deoptimizer::SOFT); 5797 Deoptimizer::SOFT);
5799 } 5798 }
5800 instr = BuildStoreKeyedGeneric(obj, key, val); 5799 instr = BuildStoreKeyedGeneric(obj, key, val);
5801 } else { 5800 } else {
5802 if (expr->AsProperty()->HasNoTypeInformation()) { 5801 if (expr->AsProperty()->IsUninitialized()) {
5803 Add<HDeoptimize>("Insufficient type feedback for keyed load", 5802 Add<HDeoptimize>("Insufficient type feedback for keyed load",
5804 Deoptimizer::SOFT); 5803 Deoptimizer::SOFT);
5805 } 5804 }
5806 instr = BuildLoadKeyedGeneric(obj, key); 5805 instr = BuildLoadKeyedGeneric(obj, key);
5807 } 5806 }
5808 AddInstruction(instr); 5807 AddInstruction(instr);
5809 } 5808 }
5810 if (position != RelocInfo::kNoPosition) instr->set_position(position); 5809 if (position != RelocInfo::kNoPosition) instr->set_position(position);
5811 *has_side_effects = instr->HasObservableSideEffects(); 5810 *has_side_effects = instr->HasObservableSideEffects();
5812 return instr; 5811 return instr;
(...skipping 4029 matching lines...) Expand 10 before | Expand all | Expand 10 after
9842 if (ShouldProduceTraceOutput()) { 9841 if (ShouldProduceTraceOutput()) {
9843 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 9842 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
9844 } 9843 }
9845 9844
9846 #ifdef DEBUG 9845 #ifdef DEBUG
9847 graph_->Verify(false); // No full verify. 9846 graph_->Verify(false); // No full verify.
9848 #endif 9847 #endif
9849 } 9848 }
9850 9849
9851 } } // namespace v8::internal 9850 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.cc ('k') | src/type-info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698