Issue 32373002: Revert "Add a soft-deopt in keyed element access when current IC is pre-monomorphic and no type fee…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 32373002: Revert "Add a soft-deopt in keyed element access when current IC is pre-monomorphic and no type fee… (Closed)

Created:
7 years, 2 months ago by Benedikt Meurer

Modified:
7 years, 2 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Add a soft-deopt in keyed element access when current IC is pre-monomorphic and no type feedback was collected." This reverts commit r17288 for breaking the mjsunit/unbox-double-arrays test on almost every platform. TBR=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17289

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -44 lines)			Patch
M	src/ast.h	View	5 chunks	+0 lines, -11 lines	0 comments	Download
M	src/ast.cc	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/type-info.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/type-info.cc	View	3 chunks	+6 lines, -20 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r17289.

Expand Messages | Collapse Messages